Add UMA stats for pen palette

ash/common/system/chromeos/palette/palette_tool_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/palette/palette_tool_manager.h"
 
 #include <algorithm>
 
 #include "ash/common/system/chromeos/palette/palette_tool.h"
 #include "base/bind.h"
+#include "base/metrics/histogram_macros.h"
 #include "ui/gfx/vector_icons_public.h"
 
 namespace ash {
 
 PaletteToolManager::PaletteToolManager(Delegate* delegate)
     : delegate_(delegate) {
   DCHECK(delegate_);
 }
 
 PaletteToolManager::~PaletteToolManager() {}
@@ skipping 10 matching lines @@
 
 void PaletteToolManager::ActivateTool(PaletteToolId tool_id) {
   PaletteTool* new_tool = FindToolById(tool_id);
   DCHECK(new_tool);
 
   PaletteTool* previous_tool = active_tools_[new_tool->GetGroup()];
 
   if (new_tool == previous_tool)
     return;
 
-  if (previous_tool)
+  if (previous_tool) {
     previous_tool->OnDisable();
+    if (previous_tool->GetToolId() == ash::PaletteToolId::LASER_POINTER) {

[jdufault, 2016/09/02 21:54:30]

nit: drop ash:: (already in the ash namespace)

[jdufault, 2016/09/02 21:54:30]

The only time we can cancel if is if we click the view again, right? What about
recording the cancel metrics inside of the "disable" if block of
CommonPaletteTool::OnViewClicked?

[xiaoyinh(OOO Sep 11-29), 2016/09/06 17:40:05]

Done.

[xiaoyinh(OOO Sep 11-29), 2016/09/06 17:40:05]

Done.

+      UMA_HISTOGRAM_ENUMERATION(
+          "Ash.Shelf.Palette.ModeCancellation",
+          ash::PaletteModeCancelType::PALETTE_MODE_LASER_POINTER_SWITCHED,
+          ash::PaletteModeCancelType::PALETTE_MODE_CANCEL_TYPE_COUNT);
+    } else if (previous_tool->GetToolId() == ash::PaletteToolId::MAGNIFY) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Ash.Shelf.Palette.ModeCancellation",
+          ash::PaletteModeCancelType::PALETTE_MODE_MAGNIFY_SWITCHED,
+          ash::PaletteModeCancelType::PALETTE_MODE_CANCEL_TYPE_COUNT);

[Ilya Sherman, 2016/09/02 21:39:30]

Please create a wrapper function for emitting to this histogram, that you could
call as

 
RecordPaletteModeCancellation(PaletteModeCancelType::PALETTE_MODE_MAGNIFY_SWITCHED)

(Note, by the way, that you're already in the "ash" namespace, and hence can
drop the "ash::" prefix.)

[xiaoyinh(OOO Sep 11-29), 2016/09/06 17:40:05]

Done.

+    }
+  }
 
   active_tools_[new_tool->GetGroup()] = new_tool;
   new_tool->OnEnable();
 
   delegate_->OnActiveToolChanged();
 }
 
 void PaletteToolManager::DeactivateTool(PaletteToolId tool_id) {
   PaletteTool* tool = FindToolById(tool_id);
   DCHECK(tool);
 
   active_tools_[tool->GetGroup()] = nullptr;
   tool->OnDisable();
+  if (tool->GetToolId() == ash::PaletteToolId::LASER_POINTER) {
+    UMA_HISTOGRAM_ENUMERATION(

[jdufault, 2016/09/02 21:54:30]

Should these UMA stats also have the AutoOpen check?

[xiaoyinh(OOO Sep 11-29), 2016/09/06 17:40:05]

AutoOpen factor are not specified for mode cancellation in the document.
So I didn't add it here. Let me know if you think it's necessary.

In general, clicks on view(including both mode activation and cancellation)
already considered autoOpened factor.  

+        "Ash.Shelf.Palette.ModeCancellation",
+        ash::PaletteModeCancelType::PALETTE_MODE_LASER_POINTER_CANCELLED,
+        ash::PaletteModeCancelType::PALETTE_MODE_CANCEL_TYPE_COUNT);
+  } else if (tool->GetToolId() == ash::PaletteToolId::MAGNIFY) {
+    UMA_HISTOGRAM_ENUMERATION(
+        "Ash.Shelf.Palette.ModeCancellation",
+        ash::PaletteModeCancelType::PALETTE_MODE_MAGNIFY_CANCELLED,
+        ash::PaletteModeCancelType::PALETTE_MODE_CANCEL_TYPE_COUNT);
+  }
 
   delegate_->OnActiveToolChanged();
 }
 
 bool PaletteToolManager::IsToolActive(PaletteToolId tool_id) {
   PaletteTool* tool = FindToolById(tool_id);
   DCHECK(tool);
 
   return active_tools_[tool->GetGroup()] == tool;
 }
@@ skipping 44 matching lines @@
 }
 
 void PaletteToolManager::HidePalette() {
   delegate_->HidePalette();
 }
 
 WmWindow* PaletteToolManager::GetWindow() {
   return delegate_->GetWindow();
 }
 
+void PaletteToolManager::RecordPaletteMetrics(ash::PaletteTrayOptions option) {
+  return delegate_->RecordPaletteMetrics(option);
+}
+
 PaletteTool* PaletteToolManager::FindToolById(PaletteToolId tool_id) {
   for (std::unique_ptr<PaletteTool>& tool : tools_) {
     if (tool->GetToolId() == tool_id)
       return tool.get();
   }
 
   return nullptr;
 }
 
 }  // namespace ash