Moving CRD Windows targets to subdirectories.

remoting/host/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//remoting/build/config/remoting_build.gni")
 
+group("all_tests") {
+  testonly = true
+
+  deps = [
+    ":unit_tests",
+  ]
+}
+
+group("all") {
+  testonly = true
+
+  deps = [
+    ":host",
+  ]
+  if (enable_me2me_host) {
+    deps += [ "//remoting/host:remoting_me2me_host" ]
+  }
+
+  if (is_chrome_branded) {
+    deps += [ ":remoting_host_branded" ]
+  }
+
+  if (!is_chromeos && !is_android && !is_ios) {
+    deps += [
+      "//remoting/host:remoting_native_messaging_host",
+      "//remoting/host:remoting_native_messaging_manifests",
+      "//remoting/host:remoting_start_host",
+      "//remoting/host/it2me:remote_assistance_host",
+    ]
+  }
+}
+
 process_version("remoting_version") {
   template_file = "//remoting/host/version.h.in"
   sources = [
     branding_path,
   ]
   output = "$target_gen_dir/version.h"
 }
 
-if (is_win) {
-  import("//remoting/host/predefines_win.gni")
-} else if (is_mac) {
-  import("//build/config/mac/rules.gni")
-  import("//third_party/icu/config.gni")
-}
-
-if (is_win) {
-  # Reference this manifest to indicate that a process is per-monitor DPI aware.
-  dpi_aware_manifest = "//remoting/host/win/dpi_aware.manifest"
-
-  # Reference this manifest to give the binary the uiAccess privilege.
-  enable_uiaccess_manifest = "//remoting/host/win/enable_uiaccess.manifest"
-
-  # Depending on this target gives the executable a default manifest with the
-  # addition of the DPI aware tag.
-  windows_manifest("dpi_aware_exe_manifest") {
-    sources = [
-      as_invoker_manifest,
-      common_controls_manifest,
-      default_compatibility_manifest,
-      dpi_aware_manifest,
-    ]
-    type = "exe"
-  }
-
-  # Depending on this target gives the executable a default manifest with the
-  # addition of the DPI aware tag and requestedExecutionLevel of
-  # requireAdministrator.
-  windows_manifest("dpi_aware_elevated_exe_manifest") {
-    sources = [
-      common_controls_manifest,
-      default_compatibility_manifest,
-      dpi_aware_manifest,
-      require_administrator_manifest,
-    ]
-    type = "exe"
-  }
-
-  # Depending on this target gives the executable a default manifest with the
-  # addition of the DPI aware tag and enables uiAccess.
-  windows_manifest("dpi_aware_uiaccess_exe_manifest") {
-    sources = [
-      common_controls_manifest,
-      default_compatibility_manifest,
-      dpi_aware_manifest,
-      enable_uiaccess_manifest,
-    ]
-    type = "exe"
-  }
-}
-
-action("credits") {
-  # We put this in $root_build_dir/gen/remoting instead of
-  # $root_build_dir/gen/remoting/host (target_gen_dir) for
-  # compatibility w/ GYP, since the installer needs the file to
-  # be at the same location.
-  about_credits_file = "$root_build_dir/gen/remoting/CREDITS.txt"
-  script = "//tools/licenses.py"
-
-  inputs = [
-    "installer/credits.tmpl",
-    "installer/credits_entry.tmpl",
-  ]
-
-  outputs = [
-    about_credits_file,
-  ]
-
-  args = [
-    "credits",
-    rebase_path(about_credits_file, root_build_dir),
-    "--file-template",
-    rebase_path("installer/credits.tmpl", root_build_dir),
-    "--entry-template",
-    rebase_path("installer/credits_entry.tmpl", root_build_dir),
-  ]
-}
-
 # This must be a static library instead of a source set because
 # remoting_unittests requires that remoting_me2me_host.cc not be pulled in,
 # which in turn depends on remoting_me2me_host_static which isn't part of that
 # build.
 #
 # TODO fix this, successful builds should not depend on static libraries
 # stripping code.
 static_library("host") {
   sources = [
     "audio_capturer.cc",
@@ skipping 232 matching lines @@
     "token_validator_base.h",
     "token_validator_factory_impl.cc",
     "token_validator_factory_impl.h",
     "touch_injector_win.cc",
     "touch_injector_win.h",
     "usage_stats_consent.h",
     "usage_stats_consent_mac.cc",
     "usage_stats_consent_win.cc",
     "username.cc",
     "username.h",
-    "win/com_imported_mstscax.tlh",
-    "win/com_security.cc",
-    "win/com_security.h",
-    "win/elevation_helpers.cc",
-    "win/elevation_helpers.h",
-    "win/launch_process_with_token.cc",
-    "win/launch_process_with_token.h",
-    "win/omaha.cc",
-    "win/omaha.h",
-    "win/rdp_client.cc",
-    "win/rdp_client.h",
-    "win/rdp_client_window.cc",
-    "win/rdp_client_window.h",
-    "win/security_descriptor.cc",
-    "win/security_descriptor.h",
-    "win/session_desktop_environment.cc",
-    "win/session_desktop_environment.h",
-    "win/session_input_injector.cc",
-    "win/session_input_injector.h",
-    "win/window_station_and_desktop.cc",
-    "win/window_station_and_desktop.h",
-    "win/worker_process_launcher.cc",
-    "win/worker_process_launcher.h",
-    "win/wts_terminal_monitor.cc",
-    "win/wts_terminal_monitor.h",
-    "win/wts_terminal_observer.h",
   ]
 
   libs = []
 
   configs += [
     "//build/config/compiler:wexit_time_destructors",
     "//remoting/build/config:version",
   ]
 
   defines = [ "WEBRTC_CHROMIUM_BUILD" ]
 
   deps = [
     "//base:i18n",
     "//components/policy/core/common",
     "//content/public/common",
     "//crypto",
     "//device/power_save_blocker",
     "//google_apis",
     "//ipc",
     "//remoting/base",
     "//remoting/host/security_key",
     "//remoting/protocol",
     "//remoting/resources",
     "//ui/base",
     "//ui/events:dom_keycode_converter",
     "//ui/events/platform",
   ]
 
+  public_deps = []
+
   if (enable_configuration_policy) {
     deps += [ "//components/policy:generated" ]
   }
 
   if (is_linux && !is_chromeos) {
     libs += [ "pam" ]
   }
 
   if (use_x11) {
     configs += [
@@ skipping 79 matching lines @@
     # this flag and usage can be removed.
     defines += [ "GN_BUILD=1" ]
     deps += [
       ":remoting_version",
       "//third_party/google_toolbox_for_mac",
     ]
   }
 
   if (is_win) {
     deps += [
-      ":messages",
-      ":remoting_lib_idl",
+      "//remoting/host/win",
+      "//remoting/host/win:messages",
+      "//remoting/host/win:remoting_lib_idl",
     ]
+
+    public_deps += [ "//remoting/host/win" ]
   }
 
   if (enable_webrtc) {
     deps += [ "//third_party/webrtc/modules/desktop_capture" ]
   }
 
   if (is_android) {
     sources -= [
       "single_window_desktop_environment.cc",
       "single_window_desktop_environment.h",
@@ skipping 88 matching lines @@
     "resizing_host_observer_unittest.cc",
     "resources_unittest.cc",
     "screen_resolution_unittest.cc",
     "server_log_entry_host_unittest.cc",
     "setup/me2me_native_messaging_host_unittest.cc",
     "setup/oauth_helper_unittest.cc",
     "setup/pin_validator_unittest.cc",
     "third_party_auth_config_unittest.cc",
     "token_validator_factory_impl_unittest.cc",
     "touch_injector_win_unittest.cc",
-    "win/rdp_client_unittest.cc",
-    "win/worker_process_launcher_unittest.cc",
   ]
 
   if (!use_x11 && is_linux) {
     sources -= [ "linux/unicode_to_keysym_unittest.cc" ]
   }
   if (use_ozone || is_chromeos) {
     sources -= [ "local_input_monitor_unittest.cc" ]
   }
   if (is_chromeos) {
     sources -= [ "linux/x_server_clipboard_unittest.cc" ]
   }
   if (is_android) {
     sources -= [ "it2me/it2me_native_messaging_host_unittest.cc" ]
   }
-  if (is_win) {
-    sources += [
-      "win/elevated_native_messaging_host.cc",
-      "win/elevated_native_messaging_host.h",
-      "win/launch_native_messaging_host_process.cc",
-      "win/launch_native_messaging_host_process.h",
-    ]
-  }
 
   configs += [ "//remoting/build/config:version" ]
 
   deps = [
     ":host",
     ":test_support",
     "//remoting/host/it2me:common",
     "//remoting/host/native_messaging",
     "//remoting/host/security_key:unit_tests",
     "//remoting/host/setup",
     "//remoting/proto",
     "//remoting/resources",
     "//skia",
     "//testing/gmock",
     "//testing/gtest",
   ]
+  if (is_win) {
+    deps += [ "//remoting/host/win:unit_tests" ]
+  }
 
   if (enable_configuration_policy) {
     deps += [ "//components/policy/core/browser:test_support" ]
   }
 }
 
-if (is_win) {
-  import("//build/toolchain/win/midl.gni")
-  import("//build/win/message_compiler.gni")
+group("remoting_host_branded") {
+  testonly = true
+  deps = []
+  if (enable_remoting_host) {
+    deps += [ ":remoting_host_installation" ]
+  }
+  if (enable_me2me_host) {
+    deps += [ "//remoting/host:remoting_me2me_host_archive" ]
+  }
+}
 
-  # TODO(brettw) these should not be generated via exec_script. This should be
-  # part of the build process rather than the metabuild. Instead, a script
-  # should generate a header containing the #defines for this as well as the
-  # IDL file with the values.
-  clsids = exec_script("win/get_clsids.py",
-                       [
-                         daemon_controller_guid,
-                         rdp_desktop_session_guid,
-                         chrome_version_full,
-                       ],
-                       "value")
-  daemon_controller_clsid = clsids[0]
-  rdp_desktop_session_clsid = clsids[1]
-
-  action("generate_idl") {
-    script = "//build/util/version.py"
-
-    inputs = [
-      "win/chromoting_lib_idl.templ",
-    ]
-    outputs = [
-      "$target_gen_dir/chromoting_lib.idl",
-    ]
-
-    args = [
-      "-e",
-      "DAEMON_CONTROLLER_CLSID='$daemon_controller_clsid'",
-      "-e",
-      "RDP_DESKTOP_SESSION_CLSID='$rdp_desktop_session_clsid'",
-      rebase_path(inputs[0], root_build_dir),
-      rebase_path(outputs[0], root_build_dir),
-    ]
-  }
-
-  midl("remoting_lib_idl") {
-    sources = get_target_outputs(":generate_idl")
-    deps = [
-      ":generate_idl",
-    ]
-  }
-
-  config("MIDL_config") {
-    if (is_clang) {
-      cflags = [
-        # MIDL generated code has a habit of omitting optional braces.
-        "-Wno-missing-braces",
-
-        # Source files generated by the MIDL compiler trigger warnings with
-        # -Wincompatible-pointer-types enabled.
-        "-Wno-incompatible-pointer-types",
-
-        # Generated code contains unused variables.
-        "-Wno-unused-variable",
-
-        # PROXYFILE_LIST_START is an extern with initializer.
-        "-Wno-extern-initializer",
-      ]
+if (enable_remoting_host) {
+  group("remoting_host_installation") {
+    deps = []
+    if (is_win) {
+      deps += [ "//remoting/host/installer/win:remoting_host_installation" ]
     }
   }
-
-  static_library("remoting_lib_ps") {
-    configs += [ ":MIDL_config" ]
-
-    defines = [
-      "ENTRY_PREFIX=Ps",
-      "REGISTER_PROXY_DLL",
-    ]
-
-    deps = [
-      ":remoting_lib_idl",
-    ]
-
-    sources = [
-      "$root_gen_dir/remoting/host/chromoting_lib.dlldata.c",
-      "$root_gen_dir/remoting/host/chromoting_lib_p.c",
-    ]
-  }
-
-  # Makes the .mc file from the .mc.jinja file.
-  remoting_localize("messages_localizing") {
-    sources = [
-      "win/host_messages.mc.jinja2",
-    ]
-    locales = remoting_locales
-    locale_dir = webapp_locale_dir
-    encoding = "utf-16"
-
-    # This target is funny. It only produces one file and the output doesn't
-    # match the input. We want to generate remoting_host_messages.mc from
-    # host_messages.mg.jinja2. GN complains if it doesn't see a pattern in the
-    # output, so the following pattern produces the name we want with a template
-    # based on the input.
-    #
-    # TODO: This is for GYP compat. We should just make the names match instead.
-    output = "$target_gen_dir/remoting_{{source_name_part}}"
-  }
-
-  # Makes the .h/.rc files from the .mc file.
-  message_compiler("messages") {
-    compile_generated_code = false
-    sources = get_target_outputs(":messages_localizing")
-    deps = [
-      ":messages_localizing",
-    ]
-  }
-
-  executable("remoting_console") {
-    configs += [ "//build/config/compiler:wexit_time_destructors" ]
-
-    defines = host_predefines + [ "BINARY=BINARY_HOST_ME2ME" ]
-
-    deps = [
-      ":dpi_aware_exe_manifest",
-      ":remoting_core",
-      ":remoting_windows_resources",
-    ]
-
-    sources = [
-      "$root_gen_dir/remoting/version.rc",
-      "win/entry_point.cc",
-    ]
-
-    ldflags = [
-      "/ENTRY:HostEntryPoint",
-      # "/NODEFAULTLIB",
-    ]
-  }
-
-  shared_library("remoting_core") {
-    configs += [ "//build/config/compiler:wexit_time_destructors" ]
-
-    defines = host_predefines + [
-                "_ATL_APARTMENT_THREADED",
-                "_ATL_CSTRING_EXPLICIT_CONSTRUCTORS",
-                "_ATL_NO_AUTOMATIC_NAMESPACE",
-                "_ATL_NO_EXCEPTIONS",
-                "BINARY=BINARY_CORE",
-                "DAEMON_CONTROLLER_CLSID=\"$daemon_controller_clsid\"",
-                "RDP_DESKTOP_SESSION_CLSID=\"$rdp_desktop_session_clsid\"",
-                "HOST_IMPLEMENTATION",
-                "ISOLATION_AWARE_ENABLED=1",
-                "STRICT",
-                "VERSION=$chrome_version_full",
-              ]
-
-    if (remoting_multi_process != 0 && remoting_rdp_session != 0) {
-      defines += [ "REMOTING_RDP_SESSION" ]
-    }
-
-    if (remoting_multi_process != 0) {
-      defines += [ "REMOTING_MULTI_PROCESS" ]
-    }
-
-    deps = [
-      ":host",
-      ":messages",
-      ":remoting_lib_idl",
-      ":remoting_lib_ps",
-      ":remoting_me2me_host_static",
-      ":remoting_windows_resources",
-      "//base",
-      "//base:base_static",
-      "//base/allocator",
-      "//base/third_party/dynamic_annotations",
-      "//build/win:default_exe_manifest",
-      "//ipc",
-      "//net",
-      "//remoting/base",
-      "//remoting/base:breakpad",
-      "//remoting/codec",
-      "//remoting/host/it2me:common",
-      "//remoting/host/native_messaging",
-      "//remoting/host/security_key:main",
-      "//remoting/host/setup",
-      "//remoting/protocol",
-      "//sandbox/win:sandbox",  # Should always use Windows version
-      "//third_party/webrtc/modules/desktop_capture",
-    ]
-
-    sources = [
-      "$root_gen_dir/remoting/core.rc",
-      "$root_gen_dir/remoting/host/remoting_host_messages.rc",
-      "$root_gen_dir/remoting/version.rc",
-      "desktop_process_main.cc",
-      "host_main.cc",
-      "host_main.h",
-      "it2me/it2me_native_messaging_host_main.cc",
-      "it2me/it2me_native_messaging_host_main.h",
-      "setup/host_starter.cc",
-      "setup/host_starter.h",
-      "setup/me2me_native_messaging_host_main.cc",
-      "setup/me2me_native_messaging_host_main.h",
-      "setup/start_host_main.cc",
-      "setup/start_host_main.h",
-      "win/chromoting_lib.rc",
-      "win/chromoting_module.cc",
-      "win/chromoting_module.h",
-      "win/core.cc",
-      "win/core_resource.h",
-      "win/elevated_native_messaging_host.cc",
-      "win/elevated_native_messaging_host.h",
-      "win/host_service.cc",
-      "win/host_service.h",
-      "win/launch_native_messaging_host_process.cc",
-      "win/launch_native_messaging_host_process.h",
-      "win/omaha.cc",
-      "win/omaha.h",
-      "win/rdp_desktop_session.cc",
-      "win/rdp_desktop_session.h",
-      "win/unprivileged_process_delegate.cc",
-      "win/unprivileged_process_delegate.h",
-      "win/wts_session_process_delegate.cc",
-      "win/wts_session_process_delegate.h",
-      "worker_process_ipc_delegate.h",
-    ]
-
-    ldflags = [
-      "/EXPORT:DllGetClassObject=PsDllGetClassObject,PRIVATE",
-      "/EXPORT:DllCanUnloadNow=PsDllCanUnloadNow,PRIVATE",
-      "/EXPORT:DllRegisterServer=PsDllRegisterServer,PRIVATE",
-      "/EXPORT:DllUnregisterServer=PsDllUnregisterServer,PRIVATE",
-    ]
-
-    libs = [
-      "comctl32.lib",
-      "rpcns4.lib",
-      "rpcrt4.lib",
-      "sas.lib",
-      "uuid.lib",
-      "wtsapi32.lib",
-    ]
-
-    if (is_clang) {
-      cflags = [ "-Wno-header-hygiene" ]
-    }
-  }
-
-  executable("remoting_desktop") {
-    configs += [
-      "//build/config/compiler:wexit_time_destructors",
-      "//build/config/win:windowed",
-    ]
-
-    defines = host_predefines + [ "BINARY=BINARY_DESKTOP" ]
-
-    deps = [
-      ":remoting_core",
-      ":remoting_windows_resources",
-    ]
-
-    if (is_official_build) {
-      deps += [ ":dpi_aware_elevated_exe_manifest" ]
-    } else {
-      deps += [ ":dpi_aware_exe_manifest" ]
-    }
-
-    sources = [
-      "$root_gen_dir/remoting/version.rc",
-      "win/entry_point.cc",
-    ]
-
-    ldflags = [
-      "/ENTRY:HostEntryPoint",
-      # "/NODEFAULTLIB",
-    ]
-  }
-
-  executable("remoting_native_messaging_host") {
-    configs += [ "//build/config/compiler:wexit_time_destructors" ]
-
-    defines = host_predefines + [ "BINARY=BINARY_NATIVE_MESSAGING_HOST" ]
-
-    deps = [
-      ":remoting_core",
-      ":remoting_windows_resources",
-      "//build/win:default_exe_manifest",
-    ]
-
-    if (is_mac) {
-      foreach(locale, remoting_locales_with_underscores) {
-        deps += [
-          ":native_messaging_host_strings_${locale}_bundle_data",
-          ":remoting_host_locale_${locale}_bundle_data",
-        ]
-      }
-      deps += [
-        ":remoting_infoplist_strings",
-        "//remoting/resources:copy_locales",
-      ]
-    }
-
-    sources = [
-      "$root_gen_dir/remoting/version.rc",
-      "setup/me2me_native_messaging_host_entry_point.cc",
-    ]
-  }
-
-  remoting_localize("remoting_windows_resources") {
-    deps = [
-      "//remoting/resources",
-    ]
-
-    sources = [
-      "win/core.rc.jinja2",
-      "win/version.rc.jinja2",
-    ]
-
-    # TODO(zijiehe): Export lastchange_path from
-    # //chrome/version.gni:process_version
-    variables = [
-      rebase_path(chrome_version_file),
-      rebase_path(remoting_version_file),
-      rebase_path("//build/util/LASTCHANGE"),
-    ]
-
-    output = "$root_gen_dir/remoting/{{source_name_part}}"
-
-    locale_dir = webapp_locale_dir
-
-    encoding = "utf-16"
-
-    locales = remoting_locales
-  }
-
-  # TODO(GYP) More Windows remoting targets from remoting_host_win.gypi
 }
 
 if (enable_remoting_host && !is_android) {
   executable("remoting_start_host") {
     sources = [
       "setup/start_host_entry_point.cc",
     ]
 
     deps = [
       "//build/config/sanitizers:deps",
     ]
 
     configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
     if (is_win) {
       defines = host_predefines + [ "BINARY=BINARY_REMOTING_START_HOST" ]
 
       deps += [
-        ":remoting_core",
-        ":remoting_windows_resources",
         "//build/win:default_exe_manifest",
+        "//remoting/host/win:remoting_core",
+        "//remoting/host/win:remoting_windows_resources",
       ]
     } else {
       sources += [
         "setup/host_starter.cc",
         "setup/host_starter.h",
         "setup/start_host_main.cc",
         "setup/start_host_main.h",
       ]
 
       deps += [ "//remoting/host/setup" ]
@@ skipping 105 matching lines @@
 
 if (enable_me2me_host) {
   static_library("remoting_me2me_host_static") {
     sources = [
       "pam_authorization_factory_posix.cc",
       "pam_authorization_factory_posix.h",
       "remoting_me2me_host.cc",
     ]
     defines = []
 
-    configs += [ "//remoting/build/config:version" ]
+    configs += [
+      "//remoting/build/config:version",
+      "//remoting/build/config:remoting_me2me_host",
+    ]
 
     deps = [
       "//base",
       "//base:i18n",
       "//components/policy/core/common",
       "//net",
       "//remoting/base",
       "//remoting/host",
       "//remoting/proto",
       "//third_party/webrtc/modules/desktop_capture",
@@ skipping 13 matching lines @@
 
     if (is_desktop_linux) {
       deps += [ "//build/config/linux/gtk2" ]
     }
     if ((is_linux && !is_chromeos) || is_mac) {
       libs = [ "pam" ]
     }
 
     if (is_mac && is_official_build) {
       sources += [ "internal/internal_mac-inl.h" ]
-      defines += [ "USE_REMOTING_MACOSX_INTERNAL" ]
-    }
-
-    if (is_win && remoting_multi_process != 0 && remoting_rdp_session != 0) {
-      defines += [ "REMOTING_RDP_SESSION" ]
-    }
-
-    if (remoting_multi_process != 0) {
-      defines += [ "REMOTING_MULTI_PROCESS" ]
     }
   }
 
   if (is_win) {
-    executable("remoting_me2me_host") {
-      configs += [
-        "//build/config/compiler:wexit_time_destructors",
-        "//build/config/win:windowed",
+    group("remoting_me2me_host") {
+      deps = [
+        "//remoting/host/win:remoting_me2me_host",
       ]
-
-      defines = host_predefines + [ "BINARY=BINARY_HOST_ME2ME" ]
-
+    }
+    group("remoting_native_messaging_host") {
       deps = [
-        ":dpi_aware_exe_manifest",
-        ":remoting_core",
-        ":remoting_windows_resources",
-      ]
-
-      sources = [
-        "$root_gen_dir/remoting/version.rc",
-        "win/entry_point.cc",
-      ]
-
-      output_name = "remoting_host"
-
-      ldflags = [
-        "/ENTRY:HostEntryPoint",
-        # "/NODEFAULTLIB",
+        "//remoting/host/win:remoting_native_messaging_host",
       ]
     }
   } else {
     if (is_mac) {
       app_target_type = "mac_app_bundle"
     } else {
       app_target_type = "executable"
     }
 
     if (is_mac) {
@@ skipping 22 matching lines @@
         sources = [
           "$root_gen_dir/remoting/CREDITS.txt",
           "remoting_me2me_host.icns",
         ]
 
         outputs = [
           "{{bundle_resources_dir}}/{{source_file_part}}",
         ]
 
         public_deps = [
-          ":credits",
+          "//remoting/host/installer:credits",
         ]
 
         if (icu_use_data_file) {
           sources += [ "$root_out_dir/icudtl.dat" ]
           public_deps += [ "//third_party/icu:icudata" ]
         }
       }
     }
 
     target(app_target_type, "remoting_me2me_host") {
@@ skipping 13 matching lines @@
       sources = [
         "host_main.cc",
         "host_main.h",
       ]
 
       if (is_mac && is_chrome_branded && is_official_build) {
         defines = [ "REMOTING_ENABLE_BREAKPAD" ]
       }
 
       deps = [
-        ":credits",
         ":remoting_me2me_host_static",
         "//build/config/sanitizers:deps",
         "//remoting/base:breakpad",
+        "//remoting/host/installer:credits",
         "//remoting/resources",
       ]
       if (is_mac) {
         foreach(locale, remoting_locales_with_underscores) {
           deps += [
             ":remoting_host_locale_${locale}_bundle_data",
             ":remoting_me2me_host_strings_${locale}_bundle_data",
           ]
         }
         deps += [
@@ skipping 44 matching lines @@
           outputs = [
             "{{bundle_resources_dir}}/$locale.lproj/{{source_file_part}}",
           ]
           deps = [
             ":remoting_infoplist_strings",
           ]
         }
       }
     }
 
+    # The [remoting_]native_messaging_host target is called differently on
+    # Linux and Mac vs Windows.
+    # TODO(sergeyu): Rename it to remoting_native_messaging_host on all
+    # platforms.
+    # TODO(nicholss): To aid in the rename effort, I am adding a link to
+    # native_messaging_host from remoting_native_messaging_host so up stream
+    # build targets need to only know about remoting_native_messaging_host.
+    # The issue is changing the target changes the executable, we could force
+    # a name in the build target or we could update the install packages to use
+    # the new name. Holding off making that choice for now.
+    group("remoting_native_messaging_host") {
+      deps = [
+        ":native_messaging_host",
+      ]
+    }
+
     target(app_target_type, "native_messaging_host") {
       if (is_mac) {
         info_plist = "setup/native_messaging_host-Info.plist"
         extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
         extra_substitutions = [
           "BUNDLE_ID=$native_messaging_host_bundle_id",
           "VERSION_FULL=$remoting_version_full",
           "VERSION_SHORT=$remoting_version_short",
           "MACOSX_DEPLOYMENT_TARGET=10.7",
         ]
@@ skipping 109 matching lines @@
         "installer/linux/build-deb.sh",
       ]
       args = [
         "-s",
         rebase_path("//"),
         "-o",
         rebase_path("$root_build_dir"),
       ]
 
       deps = [
-        ":native_messaging_host",
         ":remoting_me2me_host",
+        ":remoting_native_messaging_host",
         ":remoting_native_messaging_manifests",
         ":remoting_start_host",
         "//remoting/host/it2me:remote_assistance_host",
         "//remoting/resources",
         "//third_party/icu:icudata",
       ]
     }
   } else if (is_win) {
-    action("remoting_me2me_host_archive") {
-      script = "//remoting/host/installer/build-installer-archive.py"
-
+    group("remoting_me2me_host_archive") {
       deps = [
-        ":credits",
-        ":remoting_core",
-        ":remoting_desktop",
-        ":remoting_me2me_host",
-        ":remoting_native_messaging_host",
-        ":remoting_native_messaging_manifests",
-        ":remoting_start_host",
-        "it2me:remote_assistance_host",
-        "it2me:remote_assistance_host_uiaccess",
-        "//remoting/host/security_key:remote_security_key",
-        "//third_party/icu:icudata",
+        "//remoting/host/installer/win:remoting_me2me_host_archive",
       ]
-
-      _output = "$root_out_dir/remoting-me2me-host-$target_os.zip"
-
-      outputs = [
-        _output,
-      ]
-      if (is_chrome_branded) {
-        _branding = "Chrome"
-      } else {
-        _branding = "Chromium"
-      }
-
-      if (is_official_build) {
-        _official_build = "1"
-      } else {
-        _official_build = "0"
-      }
-
-      # Due to GN build issue http://crbug.com/633650, we need to actively set
-      # inputs parameter to tell GN to depend on these files. So change to each
-      # following files will trigger this target to be rebuilt.
-      # TODO(zijiehe): Remove inputs parameter once bug 633650 has been
-      # addressed.
-      inputs = [
-        "$root_out_dir/remote_assistance_host.exe",
-        "$root_out_dir/remote_assistance_host_uiaccess.exe",
-        "$root_out_dir/remote_security_key.exe",
-        "$root_out_dir/remoting_core.dll",
-        "$root_out_dir/remoting_desktop.exe",
-        "$root_out_dir/remoting_host.exe",
-        "$root_out_dir/remoting_native_messaging_host.exe",
-        "$root_out_dir/remoting_start_host.exe",
-        "$root_gen_dir/remoting/CREDITS.txt",
-        "$root_out_dir/remoting/com.google.chrome.remote_assistance.json",
-        "$root_out_dir/remoting/com.google.chrome.remote_desktop.json",
-        "$root_out_dir/icudtl.dat",
-      ]
-
-      _generated_files = rebase_path(inputs, root_build_dir)
-      _generated_files += [ rebase_path("//remoting/resources/chromoting.ico") ]
-
-      # _generated_dst_files must contain the same files in the same order as
-      # _generated_files, otherwise the Windows MSI will not be built correctly.
-      _generated_dst_files = [
-        "files/remote_assistance_host.exe",
-        "files/remote_assistance_host_uiaccess.exe",
-        "files/remote_security_key.exe",
-        "files/remoting_core.dll",
-        "files/remoting_desktop.exe",
-        "files/remoting_host.exe",
-        "files/remoting_native_messaging_host.exe",
-        "files/remoting_start_host.exe",
-        "files/CREDITS.txt",
-        "files/com.google.chrome.remote_assistance.json",
-        "files/com.google.chrome.remote_desktop.json",
-        "files/icudtl.dat",
-        "files/chromoting.ico",
-      ]
-
-      args =
-          [
-            rebase_path("$root_gen_dir/remoting_installation", root_build_dir),
-            rebase_path(_output, root_build_dir),
-            "--source-file-roots",
-            rebase_path("//remoting/host/installer/win"),
-            "--source-files",
-            rebase_path("//remoting/host/installer/win/chromoting.wxs"),
-            rebase_path("//remoting/host/installer/win/parameters.json"),
-
-            # Input files
-            "--generated-files",
-          ] + _generated_files +
-          [
-            # Position of files in zip file
-            "--generated-files-dst",
-          ] + _generated_dst_files +
-          [
-            # Defs
-            "--defs",
-            "BRANDING=$_branding",
-            "DAEMON_CONTROLLER_CLSID={$daemon_controller_clsid}",
-            "RDP_DESKTOP_SESSION_CLSID={$rdp_desktop_session_clsid}",
-            "VERSION=$chrome_version_full",
-            "OFFICIAL_BUILD=$_official_build",
-          ]
     }
   } else if (is_mac) {
     import("//build/config/zip.gni")
 
     action("remoting_me2me_host_archive") {
       # TODO(GYP) TODO(crbug.com/622415) This needs work and testing.
 
       # TODO(GYP) At the very least, we need to add in the localized strings.
 
       _installer_mac_files = [
@@ skipping 67 matching lines @@
                "BUNDLE_ID_HOST_SERVICE=$bundle_prefix.$host_service_name_nospace",
                "BUNDLE_ID_HOST_UNINSTALLER=$bundle_prefix.$host_uninstaller_name_nospace",
                "DMG_VOLUME_NAME=$host_name $chrome_version_full",
                "DMG_FILE_NAME=$host_name_nospace-$chrome_version_full",
                "NATIVE_MESSAGING_HOST_BUNDLE_NAME=$native_messaging_host_bundle_name",
                "REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=$remote_assistance_host_bundle_name",
                "PREFPANE_BUNDLE_NAME=$prefpane_bundle_name",
              ]
 
       deps = [
-        ":native_messaging_host",
         ":remoting_host_prefpane.prefPane",
         ":remoting_host_uninstaller",
         ":remoting_me2me_host",
+        ":remoting_native_messaging_host",
         ":remoting_native_messaging_manifests",
         "//remoting/host/it2me:remote_assistance_host",
       ]
     }
 
     _uninstaller_plist =
         "installer/mac/uninstaller/remoting_uninstaller-Info.plist"
 
     # remoting_uninstaller-InfoPlist.strings
     foreach(locale, remoting_locales_with_underscores) {
@@ skipping 180 matching lines @@
         "mac/me2me_preference_pane_confirm_pin.xib",
         "mac/me2me_preference_pane_disable.xib",
 
         #"mac/me2me_preference_pane-Info.plist",
       ]
     }
   } else {
     group("remoting_me2me_host_archive") {
     }
   }
-
-  if (is_win && is_chrome_branded) {
-    # We do not release a 64 bits binary. So to avoid any potential
-    # misunderstanding, we only build 32 bits MSI file.
-    if (!is_component_build && target_cpu == "x86") {
-      # The script uses "ia32" instead of "x86".
-      msi_script_arch = "ia32"
-
-      action("remoting_host_installation") {
-        deps = [
-          "//remoting/host:remoting_me2me_host_archive",
-        ]
-        script = "../tools/zip2msi.py"
-        outputs = [
-          "$root_out_dir/chromoting.msi",
-        ]
-        args = [
-          "--wix_path",
-          rebase_path("//third_party/wix"),
-          "--intermediate_dir",
-          rebase_path("$root_gen_dir/remoting_installation", root_build_dir),
-          "--target_arch",
-          msi_script_arch,
-          rebase_path("$root_out_dir/remoting-me2me-host-$current_os.zip",
-                      root_build_dir),
-          rebase_path(outputs[0], root_build_dir),
-        ]
-      }
-    } else {
-      group("remoting_host_installation") {
-      }
-    }
-  }
 }