Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: components/crash/content/app/crashpad_mac.mm

Issue 2308763002: Integrate Crashpad UMA (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/crash_reporter_client.cc ('k') | components/crash/content/app/crashpad_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crashpad_mac.mm
diff --git a/components/crash/content/app/crashpad_mac.mm b/components/crash/content/app/crashpad_mac.mm
index 49f04d6ef9c2c33e4313298b24f8e7ae7e3066e1..3223dddc38df570cb6c3eff4b931f07a9a66d46b 100644
--- a/components/crash/content/app/crashpad_mac.mm
+++ b/components/crash/content/app/crashpad_mac.mm
@@ -35,6 +35,7 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
bool browser_process,
bool embedded_handler) {
base::FilePath database_path; // Only valid in the browser process.
+ base::FilePath metrics_path; // Only valid in the browser process.
DCHECK(!embedded_handler); // This is not used on Mac.
if (initial_client) {
@@ -46,6 +47,7 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
// Is there a way to recover if this fails?
CrashReporterClient* crash_reporter_client = GetCrashReporterClient();
crash_reporter_client->GetCrashDumpLocation(&database_path);
+ crash_reporter_client->GetCrashMetricsLocation(&metrics_path);
#if defined(GOOGLE_CHROME_BUILD) && defined(OFFICIAL_BUILD)
// Only allow the possibility of report upload in official builds. This
@@ -91,6 +93,7 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
crashpad::CrashpadClient crashpad_client;
bool result = crashpad_client.StartHandler(handler_path,
database_path,
+ metrics_path,
url,
process_annotations,
arguments,
« no previous file with comments | « components/crash/content/app/crash_reporter_client.cc ('k') | components/crash/content/app/crashpad_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698