Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 2308763002: Integrate Crashpad UMA (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index 70f089cf9dfe93fc527f5bf565a6bc890157d32d..25ae505335864fd25cb3315d818fc27e976799af 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -121,13 +121,25 @@ class CrashReporterClient {
#endif
// The location where minidump files should be written. Returns true if
- // |crash_dir| was set.
+ // |crash_dir| was set. Windows has to use base::string16 because this code
+ // needs to work in chrome_elf, where only kernel32.dll is allowed, and
+ // base::FilePath and its dependencies pull in other DLLs.
#if defined(OS_WIN)
virtual bool GetCrashDumpLocation(base::string16* crash_dir);
#else
virtual bool GetCrashDumpLocation(base::FilePath* crash_dir);
#endif
+ // The location where metrics files should be written. Returns true if
+ // |metrics_dir| was set. Windows has to use base::string16 because this code
+ // needs to work in chrome_elf, where only kernel32.dll is allowed, and
+ // base::FilePath and its dependencies pull in other DLLs.
+#if defined(OS_WIN)
+ virtual bool GetCrashMetricsLocation(base::string16* metrics_dir);
+#else
+ virtual bool GetCrashMetricsLocation(base::FilePath* metrics_dir);
+#endif
+
// Register all of the potential crash keys that can be sent to the crash
// reporting server. Returns the size of the union of all keys.
virtual size_t RegisterCrashKeys();
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698