Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/chrome_browser_field_trials.cc

Issue 2308763002: Integrate Crashpad UMA (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_field_trials.cc
diff --git a/chrome/browser/chrome_browser_field_trials.cc b/chrome/browser/chrome_browser_field_trials.cc
index 7c5fcea6a8d43dcd9643ff0aa416ac37c8671fcb..816b9222d7ddf8c5acbf3a472a25ff7123f41577 100644
--- a/chrome/browser/chrome_browser_field_trials.cc
+++ b/chrome/browser/chrome_browser_field_trials.cc
@@ -43,16 +43,10 @@ void InstantiatePersistentHistograms() {
if (!base::PathService::Get(chrome::DIR_USER_DATA, &metrics_dir))
return;
- base::FilePath metrics_file =
- metrics_dir
- .AppendASCII(ChromeMetricsServiceClient::kBrowserMetricsName)
- .AddExtension(base::PersistentMemoryAllocator::kFileExtension);
- base::FilePath active_file =
- metrics_dir
- .AppendASCII(
- std::string(ChromeMetricsServiceClient::kBrowserMetricsName) +
- "-active")
- .AddExtension(base::PersistentMemoryAllocator::kFileExtension);
+ base::FilePath metrics_file, active_file;
+ base::GlobalHistogramAllocator::ConstructFilePaths(
+ metrics_dir, ChromeMetricsServiceClient::kBrowserMetricsName,
+ &metrics_file, &active_file);
// Move any existing "active" file to the final name from which it will be
// read when reporting initial stability metrics. If there is no file to
@@ -110,7 +104,6 @@ void InstantiatePersistentHistograms() {
// Create tracking histograms for the allocator and record storage file.
allocator->CreateTrackingHistograms(
ChromeMetricsServiceClient::kBrowserMetricsName);
- allocator->SetPersistentLocation(active_file);
}
// Create a field trial to control metrics/crash sampling for Stable on
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698