Integrate Crashpad UMA

components/crash/content/app/crash_reporter_client.h

Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index 70f089cf9dfe93fc527f5bf565a6bc890157d32d..25ae505335864fd25cb3315d818fc27e976799af 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -121,13 +121,25 @@ class CrashReporterClient {
 #endif
 
   // The location where minidump files should be written. Returns true if
-  // |crash_dir| was set.
+  // |crash_dir| was set. Windows has to use base::string16 because this code
+  // needs to work in chrome_elf, where only kernel32.dll is allowed, and
+  // base::FilePath and its dependencies pull in other DLLs.
 #if defined(OS_WIN)
   virtual bool GetCrashDumpLocation(base::string16* crash_dir);
 #else
   virtual bool GetCrashDumpLocation(base::FilePath* crash_dir);
 #endif
 
+  // The location where metrics files should be written. Returns true if
+  // |metrics_dir| was set. Windows has to use base::string16 because this code
+  // needs to work in chrome_elf, where only kernel32.dll is allowed, and
+  // base::FilePath and its dependencies pull in other DLLs.
+#if defined(OS_WIN)

[Alexei Svitkine (slow), 2016/09/15 16:49:44]

This seems a bit ugly. Have you considered just use base::string16 on all
platforms and handling it from the calling code appropriately?

[scottmg, 2016/09/15 17:41:13]

That seems reasonable. I should do GetCrashDumpLocation() at the same time and
that means fiddling with Breakpad platforms too, so I'll investigate that in a
followup if that's OK.

[Alexei Svitkine (slow), 2016/09/15 17:49:16]

SGTM.

+  virtual bool GetCrashMetricsLocation(base::string16* metrics_dir);
+#else
+  virtual bool GetCrashMetricsLocation(base::FilePath* metrics_dir);
+#endif
+
   // Register all of the potential crash keys that can be sent to the crash
   // reporting server. Returns the size of the union of all keys.
   virtual size_t RegisterCrashKeys();