Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 230873003: Remove stale include of cancelable_request.h. (Closed)

Created:
6 years, 8 months ago by jif
Modified:
6 years, 8 months ago
Reviewers:
Dan Beam, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove stale include of cancelable_request.h. The FaviconService is not a CancelableRequestProvider anymore. Fixed external classes that were incorrectly using "Handle", a type inherited from CancelableRequestProvider. BUG=359599 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263063

Patch Set 1 : Clean up. #

Patch Set 2 : Added missing #include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/favicon/favicon_service.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-09 16:00:25 UTC) #1
jif
The CQ bit was unchecked by jif@chromium.org
6 years, 8 months ago (2014-04-09 16:00:26 UTC) #2
jif
PTAL
6 years, 8 months ago (2014-04-10 09:08:58 UTC) #3
blundell
Looks like the bots aren't happy.
6 years, 8 months ago (2014-04-10 10:33:18 UTC) #4
jif
On 2014/04/10 10:33:18, blundell wrote: > Looks like the bots aren't happy. Added missing #include. ...
6 years, 8 months ago (2014-04-10 11:59:16 UTC) #5
blundell
LGTM
6 years, 8 months ago (2014-04-10 13:29:09 UTC) #6
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-10 13:49:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/230873003/100001
6 years, 8 months ago (2014-04-10 13:49:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 14:30:51 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60621
6 years, 8 months ago (2014-04-10 14:30:51 UTC) #10
jif
+dbeam for OWNER of chrome/browser/ui/webui/ntp/
6 years, 8 months ago (2014-04-10 14:41:09 UTC) #11
jif
A bit of context: The FaviconWebUIHandler's handler (or id) is something that is entirely managed ...
6 years, 8 months ago (2014-04-10 15:04:57 UTC) #12
Dan Beam
lgtm
6 years, 8 months ago (2014-04-10 15:13:08 UTC) #13
Dan Beam
(you should update the description a little bit, though)
6 years, 8 months ago (2014-04-10 15:13:21 UTC) #14
jif
The CQ bit was checked by jif@chromium.org
6 years, 8 months ago (2014-04-10 16:13:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/230873003/100001
6 years, 8 months ago (2014-04-10 16:13:39 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 20:21:21 UTC) #17
Message was sent while issue was closed.
Change committed as 263063

Powered by Google App Engine
This is Rietveld 408576698