Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 2308683003: Add a missing updateStyleAndLayout call in InsertListCommand. (Closed)

Created:
4 years, 3 months ago by dglazkov
Modified:
4 years, 3 months ago
Reviewers:
yosin, esprehn
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing updateStyleAndLayout call in InsertListCommand. This was omitted during my earlier audit. My bad. As a penance, I have to write a test. See below. BUG=642545 R=esprehn,yosin Committed: https://crrev.com/bcef514e9b3272877f89c9f353a44791b00c220d Cr-Commit-Position: refs/heads/master@{#416477}

Patch Set 1 #

Patch Set 2 : Now with proper name and comments. #

Total comments: 1

Patch Set 3 : -to. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp View 1 2 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
dglazkov
Now with proper name and comments.
4 years, 3 months ago (2016-09-04 04:56:28 UTC) #5
dglazkov
PTAL.
4 years, 3 months ago (2016-09-04 04:57:49 UTC) #8
esprehn
lgtm https://codereview.chromium.org/2308683003/diff/20001/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp File third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp (right): https://codereview.chromium.org/2308683003/diff/20001/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp#newcode39 third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp:39: // This should not to DCHECK. -to
4 years, 3 months ago (2016-09-04 05:38:14 UTC) #9
dglazkov
-to.
4 years, 3 months ago (2016-09-04 17:56:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308683003/40001
4 years, 3 months ago (2016-09-04 19:51:35 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-04 19:55:04 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 19:57:18 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bcef514e9b3272877f89c9f353a44791b00c220d
Cr-Commit-Position: refs/heads/master@{#416477}

Powered by Google App Engine
This is Rietveld 408576698