Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: ui/arc/notification/arc_notification_item.h

Issue 2308663002: Migrate ArcBitmap to use typemapping (Closed)
Patch Set: Addressed comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/arc/notification/arc_custom_notification_item.cc ('k') | ui/arc/notification/arc_notification_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/arc/notification/arc_notification_item.h
diff --git a/ui/arc/notification/arc_notification_item.h b/ui/arc/notification/arc_notification_item.h
index 3c5131b075fe26854ae89beb8e3821f1eb95c621..a2854846ac6941ff1abc237098e3a943bc062b92 100644
--- a/ui/arc/notification/arc_notification_item.h
+++ b/ui/arc/notification/arc_notification_item.h
@@ -29,7 +29,7 @@ class ArcNotificationItem {
virtual ~ArcNotificationItem();
virtual void UpdateWithArcNotificationData(
- const mojom::ArcNotificationData& data);
+ mojom::ArcNotificationDataPtr data);
// Methods called from ArcNotificationManager:
void OnClosedFromAndroid(bool by_user);
@@ -43,12 +43,11 @@ class ArcNotificationItem {
protected:
static int ConvertAndroidPriority(int android_priority);
- static gfx::Image ConvertAndroidSmallIcon(
- const mojom::ArcBitmapPtr& arc_bitmap);
- // Checks whether there is on-going |notification_|. If so, cache the |data|
- // in |newer_data_| and returns true. Otherwise, returns false.
- bool CacheArcNotificationData(const mojom::ArcNotificationData& data);
+ // Checks whether there is on-going |notification_|.
+ bool HasPendingNotification();
+ // Cache the |data| in |newer_data_|.
+ void CacheArcNotificationData(mojom::ArcNotificationDataPtr data);
// Sets the pending |notification_|.
void SetNotification(
« no previous file with comments | « ui/arc/notification/arc_custom_notification_item.cc ('k') | ui/arc/notification/arc_notification_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698