Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/arc/notification/arc_notification_manager.cc

Issue 2308663002: Migrate ArcBitmap to use typemapping (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/arc/notification/arc_notification_item.cc ('K') | « ui/arc/notification/arc_notification_item.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/arc/notification/arc_notification_manager.cc
diff --git a/ui/arc/notification/arc_notification_manager.cc b/ui/arc/notification/arc_notification_manager.cc
index 59be98a787d3d32796e5b068d8431788ba47c8e2..7e1ef5c7f7a3de22c4b8b6f831b7887db629498d 100644
--- a/ui/arc/notification/arc_notification_manager.cc
+++ b/ui/arc/notification/arc_notification_manager.cc
@@ -88,7 +88,8 @@ void ArcNotificationManager::OnNotificationPosted(
DCHECK(result.second);
it = result.first;
}
- it->second->UpdateWithArcNotificationData(*data);
+ LOG(ERROR) << data->type;
xiyuan 2016/09/07 22:09:00 nit: remove ?
yoshiki 2016/09/09 16:45:30 Done.
+ it->second->UpdateWithArcNotificationData(std::move(data));
}
void ArcNotificationManager::OnNotificationRemoved(const mojo::String& key) {
« ui/arc/notification/arc_notification_item.cc ('K') | « ui/arc/notification/arc_notification_item.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698