Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(216)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/arc/common/bitmap.typemap
Issue
2308663002
:
Migrate ArcBitmap to use typemapping (Closed)
Patch Set:
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
components/arc/BUILD.gn
components/arc/bitmap/OWNERS
components/arc/bitmap/bitmap_struct_traits.h
components/arc/bitmap/bitmap_type_converters.h
components/arc/bitmap/bitmap_type_converters.cc
components/arc/common/bitmap.typemap
components/arc/common/typemaps.gni
ui/arc/BUILD.gn
ui/arc/notification/arc_custom_notification_item.h
ui/arc/notification/arc_custom_notification_item.cc
ui/arc/notification/arc_notification_item.h
ui/arc/notification/arc_notification_item.cc
ui/arc/notification/arc_notification_manager.cc
View unified diff
|
Download patch
« components/arc/bitmap/bitmap_struct_traits.h
('K') |
« components/arc/bitmap/bitmap_type_converters.cc
('k') |
components/arc/common/typemaps.gni »
('j') |
ui/arc/notification/arc_notification_item.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
mojom = "//components/arc/common/bitmap.mojom"
2
public_headers = [ "//third_party/skia/include/core/SkBitmap.h" ]
3
traits_headers = [ "//components/arc/bitmap/bitmap_struct_traits.h" ]
4
deps = [
5
"//skia",
6
]
7
public_deps = [
8
"//skia",
9
]
10
type_mappings = [ "arc.mojom.ArcBitmap=SkBitmap" ]
OLD
NEW
« components/arc/bitmap/bitmap_struct_traits.h
('K') |
« components/arc/bitmap/bitmap_type_converters.cc
('k') |
components/arc/common/typemaps.gni »
('j') |
ui/arc/notification/arc_notification_item.cc »
('J')
Issue 2308663002: Migrate ArcBitmap to use typemapping (Closed)
Created 4 years, 3 months ago by yoshiki
Modified 4 years, 2 months ago
Reviewers: xiyuan, dcheng, Luis Héctor Chávez
Base URL:
Comments: 34
This is Rietveld
408576698