Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: src/arm64/codegen-arm64.cc

Issue 230863003: Revert "Make new space iterable when transitioning double array to objects" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/codegen-arm64.cc
diff --git a/src/arm64/codegen-arm64.cc b/src/arm64/codegen-arm64.cc
index 8d278de3cb9fca1badc4b1cfb728e5f0a0399351..0944c4bac3636feae5d2471a5709f24a747d7a9e 100644
--- a/src/arm64/codegen-arm64.cc
+++ b/src/arm64/codegen-arm64.cc
@@ -324,16 +324,6 @@ void ElementsTransitionGenerator::GenerateDoubleToObject(
Label entry;
__ B(&entry);
- Label gc_cleanup;
- __ Bind(&gc_cleanup);
-#ifdef VERIFY_HEAP
- // Make sure new space is iterable if we are verifying the heap.
- __ Mov(x5, Operand(masm->isolate()->factory()->one_pointer_filler_map()));
- __ Str(x5, MemOperand(dst_elements, kPointerSize, PostIndex));
- __ Cmp(dst_elements, dst_end);
- __ B(lt, &gc_cleanup);
-#endif
-
// Call into runtime if GC is required.
__ Bind(&gc_required);
__ Pop(value, key, receiver, target_map);
@@ -349,7 +339,7 @@ void ElementsTransitionGenerator::GenerateDoubleToObject(
// Non-hole double, copy value into a heap number.
Register heap_num = x5;
- __ AllocateHeapNumber(heap_num, &gc_cleanup, x6, x4,
+ __ AllocateHeapNumber(heap_num, &gc_required, x6, x4,
x13, heap_num_map);
__ Mov(x13, dst_elements);
__ Str(heap_num, MemOperand(dst_elements, kPointerSize, PostIndex));
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698