Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 230863002: Version 3.25.28.11 (merged r20501) (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Version 3.25.28.11 (merged r20501) Make sure value is a heap number when reusing the double box in BinaryOpICStub. R=dcarney@chromium.org BUG=359525 Committed: https://code.google.com/p/v8/source/detail?r=20622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-359525.js View 1 chunk +14 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
6 years, 8 months ago (2014-04-09 13:24:37 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-09 13:27:24 UTC) #2
Hannes Payer (out of office)
6 years, 8 months ago (2014-04-09 13:28:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20622.

Powered by Google App Engine
This is Rietveld 408576698