components/tracing/core/proto_utils.cc - Issue 2308583003: tracing v2: Introduce TraceBufferReader to read-back the trace buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/proto_utils.cc

Issue 2308583003: tracing v2: Introduce TraceBufferReader to read-back the trace buffer (Closed)

Patch Set: DISALLOW_COPY_AND_ASSIGN + cctype for isalnum Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/core/proto_utils.cc

diff --git a/components/tracing/core/proto_utils.cc b/components/tracing/core/proto_utils.cc

index 8e80d31c5069613bcbb5dd09ed88593167516169..0b410b49f3e444e3e27dbbb8a9839e39a7fa6bce 100644

--- a/components/tracing/core/proto_utils.cc

+++ b/components/tracing/core/proto_utils.cc

@@ -74,6 +74,7 @@ const uint8_t* ParseField(const uint8_t* start,

}

case kFieldTypeLengthDelimited: {

pos = ParseVarInt(pos, end, field_intvalue);

+ CHECK_LE(*field_intvalue, kMaxMessageLength);

pos += *field_intvalue;

CHECK_PTR_LE(pos, end);

break;