Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "components/tracing/core/string_interning.h" | |
| 6 | |
| 7 namespace tracing { | |
| 8 namespace v2 { | |
| 9 | |
| 10 // TODO(primiano): there is a possibile optimization here: if we somehow | |
| 11 // guarantee that kInternedStringBase is always laid out before any other string | |
| 12 // in the binary, we can minimize the ptr distance and hence reduce the number | |
| 13 // of bytes required to VarInt-encode it. Very likely this can be done using | |
| 14 // __attribute__((section(X))) on Linux or __attribute__((section("__TEXT,X"))) | |
| 15 // on OSX. | |
|
kraynov
2016/09/08 16:10:01
Yep, maybe dynamic linker has some tricks as well.
Primiano Tucci (use gerrit)
2016/09/13 14:40:24
Acknowledged.
| |
| 16 const char kInternedStringBase[] = "Chrome Tracing v2"; | |
|
oystein (OOO til 10th of July)
2016/09/09 00:27:34
supernit: just "Tracing v2", there's other embedde
Primiano Tucci (use gerrit)
2016/09/13 14:40:24
Done.
| |
| 17 | |
| 18 } // namespace v2 | |
| 19 } // namespace tracing | |
| OLD | NEW |