|
|
Created:
4 years, 3 months ago by sakal-chromium Modified:
4 years, 3 months ago CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove source->Stop() call from chromoting WebRTC video stream.
Removing this call should be safe because the call just does following
things:
1. Sets started_ to false in VideoCapturerTrackSource. This doesn't
matter since it will be destroyed soon.
2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the
dummy video captuer to CS_STOPPED. This doesn't matter since it will be
destroyed soon.
Motivation behind this change is that we want to remove Restart and Stop
from VideoTrackSourceInterface. This code is the last usage of these
methods.
Committed: https://crrev.com/6c7db377353fed02f6ac2052e86ff8ad89729245
Cr-Commit-Position: refs/heads/master@{#416290}
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSource interface. This code is the last usage of these methods. ========== to ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSource interface. This code is the last usage of these methods. ==========
sakal@chromium.org changed reviewers: + magjed@webrtc.org, sergeyu@chromium.org
sakal@chromium.org changed required reviewers: + sergeyu@chromium.org
sakal@chromium.org changed reviewers: + magjed@chromium.org - magjed@webrtc.org
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm
Description was changed from ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSource interface. This code is the last usage of these methods. ========== to ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. ==========
lgtm
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. ========== to ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. ========== to ========== Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. Committed: https://crrev.com/6c7db377353fed02f6ac2052e86ff8ad89729245 Cr-Commit-Position: refs/heads/master@{#416290} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6c7db377353fed02f6ac2052e86ff8ad89729245 Cr-Commit-Position: refs/heads/master@{#416290} |