Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2308543002: Remove source->Stop() call from chromoting WebRTC video stream. (Closed)

Created:
4 years, 3 months ago by sakal-chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove source->Stop() call from chromoting WebRTC video stream. Removing this call should be safe because the call just does following things: 1. Sets started_ to false in VideoCapturerTrackSource. This doesn't matter since it will be destroyed soon. 2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the dummy video captuer to CS_STOPPED. This doesn't matter since it will be destroyed soon. Motivation behind this change is that we want to remove Restart and Stop from VideoTrackSourceInterface. This code is the last usage of these methods. Committed: https://crrev.com/6c7db377353fed02f6ac2052e86ff8ad89729245 Cr-Commit-Position: refs/heads/master@{#416290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M remoting/protocol/webrtc_video_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
sakal-chromium
PTAL
4 years, 3 months ago (2016-09-02 12:37:28 UTC) #10
magjed_chromium
lgtm
4 years, 3 months ago (2016-09-02 12:41:30 UTC) #11
Sergey Ulanov
lgtm
4 years, 3 months ago (2016-09-02 17:21:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308543002/1
4 years, 3 months ago (2016-09-02 17:22:33 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 17:26:53 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 17:29:57 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c7db377353fed02f6ac2052e86ff8ad89729245
Cr-Commit-Position: refs/heads/master@{#416290}

Powered by Google App Engine
This is Rietveld 408576698