Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: content/browser/renderer_host/media/video_capture_manager.cc

Issue 2308533003: Break tight coupling of VideoCaptureDeviceClient to renderer_host (Closed)
Patch Set: miu's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/video_capture_manager.cc
diff --git a/content/browser/renderer_host/media/video_capture_manager.cc b/content/browser/renderer_host/media/video_capture_manager.cc
index 371e26b0c654e3c54b22d6ef9ac10e5e796de15e..45f82afb979836eccf74ad55280d8bc7029c4d35 100644
--- a/content/browser/renderer_host/media/video_capture_manager.cc
+++ b/content/browser/renderer_host/media/video_capture_manager.cc
@@ -412,7 +412,7 @@ void VideoCaptureManager::DoStopDevice(DeviceEntry* entry) {
DVLOG(3) << "DoStopDevice. Send stop request for device = " << entry->id
<< " serial_id = " << entry->serial_id << ".";
- entry->video_capture_controller()->DoLogOnIOThread(
+ entry->video_capture_controller()->OnLog(
base::StringPrintf("Stopping device: id: %s", entry->id.c_str()));
if (entry->video_capture_device()) {
@@ -460,7 +460,7 @@ void VideoCaptureManager::HandleQueuedStartRequest() {
// held in the browser-side VideoCaptureDevice::Name structure.
const DeviceInfo* found = GetDeviceInfoById(entry->id);
if (found) {
- entry->video_capture_controller()->DoLogOnIOThread(
+ entry->video_capture_controller()->OnLog(
base::StringPrintf("Starting device: id: %s, name: %s, api: %s",
found->descriptor.device_id.c_str(),
found->descriptor.GetNameAndModel().c_str(),
@@ -480,8 +480,8 @@ void VideoCaptureManager::HandleQueuedStartRequest() {
"Error on %s:%d: device %s unknown. Maybe recently disconnected?",
__FILE__, __LINE__, entry->id.c_str());
DLOG(ERROR) << log_message;
- entry->video_capture_controller()->DoLogOnIOThread(log_message);
- entry->video_capture_controller()->DoErrorOnIOThread();
+ entry->video_capture_controller()->OnLog(log_message);
+ entry->video_capture_controller()->OnError();
// Drop the failed start request.
device_start_queue_.pop_front();
« no previous file with comments | « content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698