Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2308513002: CSP: Measure whether we can treat '<meta http-refresh>' as inline script. (Closed)

Created:
4 years, 3 months ago by Mike West
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: Measure whether we can treat '<meta http-refresh>' as inline script. https://github.com/w3c/webappsec-csp/issues/112 notes that '<meta>' has some script-like capabilities that aren't currently covered by CSP. This patch adds metrics for usage of 'Set-Cookie' and 'Refresh' in documents that block inline script. If it turns out that the intersection is low, perhaps we can make this backwards-incompatible change. R=jochen@chromium.org Committed: https://crrev.com/d171843d5e59aea28a3d3845422b94a39c221143 Cr-Commit-Position: refs/heads/master@{#416261}

Patch Set 1 #

Patch Set 2 : Ugh. #

Patch Set 3 : Rebase+Histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Mike West
WDYT, Jochen? No actual change, just metrics.
4 years, 3 months ago (2016-09-02 09:56:12 UTC) #3
Mike West
On 2016/09/02 at 09:56:12, Mike West (OOO until 29th) wrote: > WDYT, Jochen? No actual ...
4 years, 3 months ago (2016-09-02 09:56:44 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-02 09:59:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308513002/40001
4 years, 3 months ago (2016-09-02 11:37:10 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 14:09:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 14:12:58 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d171843d5e59aea28a3d3845422b94a39c221143
Cr-Commit-Position: refs/heads/master@{#416261}

Powered by Google App Engine
This is Rietveld 408576698