Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2308503002: Revert of Paint solid color backgrounds which are equivalent to locally attached into scrolling c... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scrollcontent-paint-bg
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 579565e066cf12e57ea1587261104206f944ed2b..6f789250622089910630a288b06f28e01c14d76d 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -1266,6 +1266,23 @@
bool ComputedStyle::hasEntirelyFixedBackground() const
{
return allLayersAreFixed(backgroundLayers());
+}
+
+bool ComputedStyle::hasEntirelyLocalBackground() const
+{
+ const FillLayer* layer = &backgroundLayers();
+ for (; layer; layer = layer->next()) {
+ if (layer->attachment() == LocalBackgroundAttachment)
+ continue;
+ // Solid color layers with a background clip of the padding box can be treated
+ // as local.
+ // TODO(flackr): We can handle other fill boxes with solid colors as long as they
+ // are essentially the same (i.e. PaddingFillBox == ContentFillBox when padding = 0).
+ if (!layer->image() && !layer->next() && layer->clip() == PaddingFillBox)
+ continue;
+ return false;
+ }
+ return true;
}
const CounterDirectiveMap* ComputedStyle::counterDirectives() const
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698