Make FuzzedDataProvider vend std::strings

net/url_request/url_request_data_job_fuzzer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
 #include "base/run_loop.h"
@@ skipping 36 matching lines @@
     uint32_t buf_size = provider.ConsumeUint32InRange(1, 127);  // 7 bits.
     scoped_refptr<net::IOBuffer> buf(
         new net::IOBuffer(static_cast<size_t>(buf_size)));
     buf_.swap(buf);
 
     // Generate a range header, and a bool determining whether to use it.
     // Generate the header regardless of the bool value to keep the data URL and
     // header in consistent byte addresses so the fuzzer doesn't have to work as
     // hard.
     bool use_range = provider.ConsumeBool();
-    base::StringPiece range(provider.ConsumeBytes(kMaxLengthForFuzzedRange));
+    std::string range(provider.ConsumeBytes(kMaxLengthForFuzzedRange));
 
     // Generate a sequence of reads sufficient to read the entire data URL.
     size_t simulated_bytes_read = 0;
     while (simulated_bytes_read < provider.remaining_bytes()) {
       size_t read_length = provider.ConsumeUint32InRange(1, buf_size);
       read_lengths_.push_back(read_length);
       simulated_bytes_read += read_length;
     }
 
     // The data URL is the rest of the fuzzed data with "data:" prepended, to
     // ensure that if it's a URL, it's a data URL. If the URL is invalid just
     // use a test variant, so the fuzzer has a chance to execute something.
     std::string data_url_string =
-        std::string("data:") + provider.ConsumeRemainingBytes().as_string();
+        std::string("data:") + provider.ConsumeRemainingBytes();
     GURL data_url(data_url_string);
     if (!data_url.is_valid())
       data_url = GURL("data:text/html;charset=utf-8,<p>test</p>");
 
     // Create a URLRequest with the given data URL and start reading
     // from it.
     std::unique_ptr<net::URLRequest> request =
         context_.CreateRequest(data_url, net::DEFAULT_PRIORITY, this);
     if (use_range) {
-      std::string range_str = range.as_string();
-      if (!net::HttpUtil::IsValidHeaderValue(range_str))
-        range_str = "bytes=3-";
-      request->SetExtraRequestHeaderByName("Range", range_str, true);
+      if (!net::HttpUtil::IsValidHeaderValue(range))
+        range = "bytes=3-";
+      request->SetExtraRequestHeaderByName("Range", range, true);
     }
 
     // Block the thread while the request is read.
     base::RunLoop read_loop;
     read_loop_ = &read_loop;
     request->Start();
     read_loop.Run();
     read_loop_ = nullptr;
     return 0;
   }
@@ skipping 68 matching lines @@
   base::RunLoop* read_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestDataJobFuzzerHarness);
 };
 
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   // Using a static singleton test harness lets the test run ~3-4x faster.
   return URLRequestDataJobFuzzerHarness::GetInstance()
       ->CreateAndReadFromDataURLRequest(data, size);
 }