Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 230843004: Reland r262568 "Encrypted Media: Check container mime type in MediaDrmBridge". (Closed)

Created:
6 years, 8 months ago by xhwang
Modified:
6 years, 8 months ago
Reviewers:
qinmin, ddorwin, dmazzoni
CC:
chromium-reviews, fischman+watch_chromium.org, jam, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Reland r262568 "Encrypted Media: Check container mime type in MediaDrmBridge". This CL relands r262568 with NO additional changes. The original CL was reverted to help investigate some test failure, which turned out to be unrelated to this CL. Android MediaDrm API supports container mime type check in isCryptoSchemeSupported (UUID uuid, String mimeType): http://developer.android.com/reference/android/media/MediaDrm.html#isCryptoSchemeSupported(java.util.UUID, java.lang.String) This CL hook this API up in MediaDrmBridge. Also, Chromium will always query the codec/container type it is interested in (e.g. MP4 and WebM). TBR=ddorwin@chromium.org,qinmin@chromium.org,dmazzoni@chromium.org BUG=350481 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -53 lines) Patch
M chrome/browser/media/encrypted_media_message_filter_android.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaDrmBridge.java View 2 chunks +6 lines, -2 lines 0 comments Download
M media/base/android/media_drm_bridge.h View 1 chunk +5 lines, -3 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 4 chunks +53 lines, -21 lines 0 comments Download
M media/base/android/media_drm_bridge_unittest.cc View 2 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 8 months ago (2014-04-09 17:03:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/230843004/1
6 years, 8 months ago (2014-04-09 17:04:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 18:15:05 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-09 18:15:05 UTC) #4
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 8 months ago (2014-04-09 18:29:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/230843004/1
6 years, 8 months ago (2014-04-09 18:29:33 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:46:48 UTC) #7
Message was sent while issue was closed.
Change committed as 262828

Powered by Google App Engine
This is Rietveld 408576698