Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2308423002: Generalized the storage strategy used by UpdateProfileCounts. (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
Reviewers:
bcwhite
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generalized the storage strategy used by UpdateProfileCounts. This simplifies adding new such stats. BUG=643647 TEST=covered by GoogleUpdateSettingsTest.UpdateProfileCounts* Committed: https://crrev.com/f7c30a5abe40796ca0972f541324c6a117d3ca64 Cr-Commit-Position: refs/heads/master@{#416724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M chrome/installer/util/google_update_settings.cc View 5 chunks +30 lines, -31 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
grt (UTC plus 2)
Hi Brian. Time for a quick review?
4 years, 3 months ago (2016-09-05 07:59:31 UTC) #4
bcwhite
lgtm
4 years, 3 months ago (2016-09-06 17:07:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308423002/20001
4 years, 3 months ago (2016-09-06 19:56:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-06 20:52:50 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:55:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7c30a5abe40796ca0972f541324c6a117d3ca64
Cr-Commit-Position: refs/heads/master@{#416724}

Powered by Google App Engine
This is Rietveld 408576698