Chromium Code Reviews| Index: chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc |
| diff --git a/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc b/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc |
| index cf878e8b32e5ea8d1ac8802d4fdd06ac61df0d8f..4b2f9df2a280a9fd6a88998e251d46a35af90379 100644 |
| --- a/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc |
| +++ b/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc |
| @@ -65,10 +65,11 @@ TEST_F(BinaryFeatureExtractorWinTest, UntrustedSignedBinary) { |
| } |
| TEST_F(BinaryFeatureExtractorWinTest, TrustedBinary) { |
| - // wow_helper.exe is signed using Google's signing certifiacte. |
| + // disable_outdated_build_detector.exe is dual signed using Google's signing |
| + // certifiacte. |
| ClientDownloadRequest_SignatureInfo signature_info; |
| binary_feature_extractor_->CheckSignature( |
| - testdata_path_.Append(L"wow_helper.exe"), |
| + testdata_path_.Append(L"disable_outdated_build_detector.exe"), |
| &signature_info); |
| ASSERT_EQ(1, signature_info.certificate_chain_size()); |
|
Will Harris
2016/09/06 16:55:17
I'm surprised none of these values changed...?
grt (UTC plus 2)
2016/09/07 10:03:01
My understanding is that this is 1 because WinVeri
|
| std::vector<scoped_refptr<net::X509Certificate> > certs; |
| @@ -76,9 +77,9 @@ TEST_F(BinaryFeatureExtractorWinTest, TrustedBinary) { |
| ASSERT_EQ(3u, certs.size()); |
| EXPECT_EQ("Google Inc", certs[0]->subject().common_name); |
| - EXPECT_EQ("VeriSign Class 3 Code Signing 2009-2 CA", |
| + EXPECT_EQ("VeriSign Class 3 Code Signing 2010 CA", |
| certs[1]->subject().common_name); |
| - EXPECT_EQ("Class 3 Public Primary Certification Authority", |
| + EXPECT_EQ("VeriSign Trust Network", |
| certs[2]->subject().organization_unit_names[0]); |
| EXPECT_TRUE(signature_info.trusted()); |
| @@ -198,7 +199,7 @@ TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesTrustedSigned) { |
| ClientDownloadRequest_ImageHeaders image_headers; |
| google::protobuf::RepeatedPtrField<std::string> signed_data; |
| ASSERT_TRUE(binary_feature_extractor_->ExtractImageFeatures( |
| - testdata_path_.AppendASCII("wow_helper.exe"), |
| + testdata_path_.AppendASCII("disable_outdated_build_detector.exe"), |
| BinaryFeatureExtractor::kDefaultOptions, &image_headers, &signed_data)); |
| ASSERT_EQ(1, signed_data.size()); |
| ASSERT_LT(0U, signed_data.Get(0).size()); |