Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2308393002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index 36a1f2ad5b7be1cc22836cc07b21ac6b3616eb6b..abb1ff49cf72e94a09e6a7e034c8f3ff4825213c 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -247,6 +247,13 @@ protected:
virtual void checkNotify();
+ enum class MarkFinishedOption {
+ ShouldMarkFinished,
+ DoNotMarkFinished
+ };
+ void notifyClientsInternal(MarkFinishedOption);
+ void markClientFinished(ResourceClient*);
+
virtual void destroyDecodedDataForFailedRevalidation() { }
void setEncodedSize(size_t);
@@ -285,8 +292,6 @@ protected:
virtual bool isSafeToUnlock() const { return false; }
virtual void destroyDecodedDataIfPossible() { }
- virtual void markClientsAndObserversFinished();
-
// Returns the memory dump name used for tracing. See Resource::onMemoryDump.
String getMemoryDumpName() const;
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698