Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf. (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 params.multiSelect = fileChooser->settings().allowsMultipleFiles; 711 params.multiSelect = fileChooser->settings().allowsMultipleFiles;
712 params.directory = fileChooser->settings().allowsDirectoryUpload; 712 params.directory = fileChooser->settings().allowsDirectoryUpload;
713 params.acceptTypes = fileChooser->settings().acceptTypes(); 713 params.acceptTypes = fileChooser->settings().acceptTypes();
714 params.selectedFiles = fileChooser->settings().selectedFiles; 714 params.selectedFiles = fileChooser->settings().selectedFiles;
715 if (params.selectedFiles.size() > 0) 715 if (params.selectedFiles.size() > 0)
716 params.initialValue = params.selectedFiles[0]; 716 params.initialValue = params.selectedFiles[0];
717 params.useMediaCapture = fileChooser->settings().useMediaCapture; 717 params.useMediaCapture = fileChooser->settings().useMediaCapture;
718 params.needLocalPath = fileChooser->settings().allowsDirectoryUpload; 718 params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;
719 params.requestor = frame->document()->url(); 719 params.requestor = frame->document()->url();
720 720
721 WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompleti onImpl(fileChooser); 721 WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompleti onImpl(std::move(fileChooser));
722 if (client->runFileChooser(params, chooserCompletion)) 722 if (client->runFileChooser(params, chooserCompletion))
723 return; 723 return;
724 // Choosing failed, so do callback with an empty list. 724 // Choosing failed, so do callback with an empty list.
725 chooserCompletion->didChooseFile(WebVector<WebString>()); 725 chooserCompletion->didChooseFile(WebVector<WebString>());
726 } 726 }
727 727
728 void ChromeClientImpl::enumerateChosenDirectory(FileChooser* fileChooser) 728 void ChromeClientImpl::enumerateChosenDirectory(FileChooser* fileChooser)
729 { 729 {
730 WebViewClient* client = m_webView->client(); 730 WebViewClient* client = m_webView->client();
731 if (!client) 731 if (!client)
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
1136 ScreenOrientationController::provideTo(frame, client ? client->webScreenOrie ntationClient() : nullptr); 1136 ScreenOrientationController::provideTo(frame, client ? client->webScreenOrie ntationClient() : nullptr);
1137 if (RuntimeEnabledFeatures::presentationEnabled()) 1137 if (RuntimeEnabledFeatures::presentationEnabled())
1138 PresentationController::provideTo(frame, client ? client->presentationCl ient() : nullptr); 1138 PresentationController::provideTo(frame, client ? client->presentationCl ient() : nullptr);
1139 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) 1139 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
1140 provideAudioOutputDeviceClientTo(frame, AudioOutputDeviceClientImpl::cre ate()); 1140 provideAudioOutputDeviceClientTo(frame, AudioOutputDeviceClientImpl::cre ate());
1141 if (RuntimeEnabledFeatures::installedAppEnabled()) 1141 if (RuntimeEnabledFeatures::installedAppEnabled())
1142 InstalledAppController::provideTo(frame, client ? client->installedAppCl ient() : nullptr); 1142 InstalledAppController::provideTo(frame, client ? client->installedAppCl ient() : nullptr);
1143 } 1143 }
1144 1144
1145 } // namespace blink 1145 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/HashMap.h » ('j') | third_party/WebKit/Source/wtf/HashMap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698