remoting/host/BUILD.gn - Issue 2308313003: gn: Generalize process_version() and move it to build/util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)

Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/BUILD.gn

diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn

index fd1745dc51e5f3963f5c483aa2f10deb425215e6..add25e67721e765b9a82cab5c7f800ab10c3a3ad 100644

--- a/remoting/host/BUILD.gn

+++ b/remoting/host/BUILD.gn

@@ -2,6 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+import("//build/util/process_version.gni")

import("//remoting/build/config/remoting_build.gni")

process_version("remoting_version") {

@@ -964,8 +965,6 @@ if (is_win) {

"win/version.rc.jinja2",

]

- # TODO(zijiehe): Export lastchange_path from

- # //chrome/version.gni:process_version

variables = [

rebase_path(chrome_version_file),

rebase_path(remoting_version_file),

« no previous file with comments | « remoting/build/config/remoting_build.gni ('k') | third_party/widevine/cdm/BUILD.gn » ('j') | no next file with comments »