Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: media/cdm/ppapi/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/crnet/BUILD.gn ('k') | remoting/build/config/remoting_build.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/ppapi/BUILD.gn
diff --git a/media/cdm/ppapi/BUILD.gn b/media/cdm/ppapi/BUILD.gn
index cc63fd899a4fb8f9f8515c4eee5e6082ca441c24..bb7c65f36ff57283047310abbfff2d68c2861f76 100644
--- a/media/cdm/ppapi/BUILD.gn
+++ b/media/cdm/ppapi/BUILD.gn
@@ -3,7 +3,7 @@
# found in the LICENSE file.
import("//build/config/features.gni")
-import("//chrome/version.gni") # TODO layering violation!
+import("//chrome/process_version_rc_template.gni")
import("//media/cdm/ppapi/cdm_paths.gni")
import("//media/cdm/ppapi/ppapi_cdm_adapter.gni")
import("//media/media_options.gni")
@@ -50,9 +50,8 @@ shared_library("clearkeycdm") {
}
}
-process_version("clearkeycdmadapter_resources") {
+process_version_rc_template("clearkeycdmadapter_resources") {
visibility = [ ":*" ]
- template_file = chrome_version_rc_template
sources = [
"//media/clearkeycdmadapter.ver",
"external_clear_key/BRANDING",
« no previous file with comments | « ios/crnet/BUILD.gn ('k') | remoting/build/config/remoting_build.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698