Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crypto/BUILD.gn ('k') | components/cronet/ios/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index cde4b92cec31a091cd97fd541b8e2e0aa2806ffb..a4f38afb3bc7766d6cf188be4205436c4664de77 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -5,8 +5,8 @@
import("//build/buildflag_header.gni")
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
+import("//build/util/process_version.gni")
import("//build/util/version.gni")
-import("//chrome/version.gni")
import("//testing/test.gni")
import("//third_party/protobuf/proto_library.gni")
import("//url/features.gni")
@@ -95,6 +95,10 @@ _generated_api_version_java =
process_version("cronet_api_version_java") {
template_file = "api/src/org/chromium/net/ApiVersion.template"
+ sources = [
+ "//build/util/LASTCHANGE",
+ "//chrome/VERSION",
+ ]
output = _generated_api_version_java
}
@@ -116,6 +120,10 @@ _generated_impl_version_java =
process_version("cronet_impl_version_java") {
template_file = "java/src/org/chromium/net/impl/ImplVersion.template"
+ sources = [
+ "//build/util/LASTCHANGE",
+ "//chrome/VERSION",
+ ]
output = _generated_impl_version_java
}
« no previous file with comments | « chromecast/crypto/BUILD.gn ('k') | components/cronet/ios/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698