Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/host/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move process_version_rc_template() to chrome// Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/chrome_build.gni ('K') | « remoting/build/config/remoting_build.gni ('k') | third_party/widevine/cdm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index f7b88316c0f09c8e17f72f1900d4cbe337f33b94..28c6d418f5124bbfbdd514eef4ecd998829ce590 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/util/process_version.gni")
import("//remoting/build/config/remoting_build.gni")
process_version("remoting_version") {
@@ -967,8 +968,6 @@ if (is_win) {
"win/version.rc.jinja2",
]
- # TODO(zijiehe): Export lastchange_path from
- # //chrome/version.gni:process_version
variables = [
rebase_path(chrome_version_file),
rebase_path(remoting_version_file),
« build/config/chrome_build.gni ('K') | « remoting/build/config/remoting_build.gni ('k') | third_party/widevine/cdm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698