Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: extensions/shell/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Fix chromecast Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/BUILD.gn
diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn
index 972a3ea43a118bbd8fad0eaecab267200df17d04..5afbe3e0d26c41fc73ce76fdc244124a3040d5c1 100644
--- a/extensions/shell/BUILD.gn
+++ b/extensions/shell/BUILD.gn
@@ -4,11 +4,7 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
-
-# Technically, this directory should not depend on files from src/chrome, but
-# that's where the VERSION file is. This should probably all be moved to
-# src/build.
-import("//chrome/version.gni")
+import("//build/util/process_version.gni")
import("//testing/test.gni")
import("//tools/grit/grit_rule.gni")
@@ -281,6 +277,10 @@ test("app_shell_unittests") {
process_version("version_header") {
template_file = "common/version.h.in"
+ sources = [
+ "//build/util/LASTCHANGE",
+ "//chrome/VERSION",
+ ]
output = "$target_gen_dir/common/version.h"
}

Powered by Google App Engine
This is Rietveld 408576698