Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3378)

Unified Diff: chrome/common/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Fix chromecast Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 2c6d4fcd5378be13ac2f9acef2679140cc6f5872..bb8b95a683debeb01a32de3a42fd3f204b3ff674 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -3,8 +3,9 @@
# found in the LICENSE file.
import("//build/buildflag_header.gni")
+import("//build/config/chrome_build.gni")
+import("//build/util/process_version.gni")
import("//chrome/common/features.gni")
-import("//chrome/version.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//tools/grit/grit_rule.gni")
@@ -510,8 +511,11 @@ process_version("version_header") {
# currently depends on this.
#visibility = [ ":*" ]
- # This one just uses the custom template and no separate sources.
- sources = []
+ sources = [
+ "//build/util/LASTCHANGE",
+ "//chrome/VERSION",
+ branding_file_path,
+ ]
template_file = "chrome_version.h.in"
output = "$target_gen_dir/chrome_version.h"

Powered by Google App Engine
This is Rietveld 408576698