Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5079)

Unified Diff: chrome/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Fix chromecast Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 0534fd03c7f9da88b387c1e27819eb9831120f21..b4cd419208ccb020c252a3039ba488375241cf0e 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -11,9 +11,9 @@ import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build/config/win/console_app.gni")
import("//build/config/win/manifest.gni")
+import("//build/util/process_version.gni")
import("//chrome/chrome_repack_locales.gni")
import("//chrome/common/features.gni")
-import("//chrome/version.gni")
import("//third_party/widevine/cdm/widevine.gni")
import("//ui/base/ui_features.gni")
import("//v8/gni/v8.gni")
@@ -1212,16 +1212,14 @@ group("child_dependencies") {
}
if (is_win) {
- process_version("chrome_exe_version") {
- template_file = chrome_version_rc_template
+ process_version_rc_template("chrome_exe_version") {
sources = [
"app/chrome_exe.ver",
]
output = "$target_gen_dir/chrome_exe_version.rc"
}
- process_version("chrome_dll_version") {
- template_file = chrome_version_rc_template
+ process_version_rc_template("chrome_dll_version") {
sources = [
"app/chrome_dll.ver",
]
@@ -1237,16 +1235,14 @@ if (is_win) {
type = "dll"
}
- process_version("nacl64_exe_version") {
- template_file = chrome_version_rc_template
+ process_version_rc_template("nacl64_exe_version") {
sources = [
"app/nacl64_exe.ver",
]
output = "$target_gen_dir/nacl64_exe_version.rc"
}
- process_version("other_version") {
- template_file = chrome_version_rc_template
+ process_version_rc_template("other_version") {
sources = [
"app/other.ver",
]

Powered by Google App Engine
This is Rietveld 408576698