Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/compiler/compiler.gni") 5 import("//build/config/compiler/compiler.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//build/config/win/visual_studio_version.gni") 8 import("//build/config/win/visual_studio_version.gni")
9 import("//chrome/process_version_rc_template.gni")
9 import("//chrome/test/mini_installer/mini_installer_test.gni") 10 import("//chrome/test/mini_installer/mini_installer_test.gni")
10 import("//chrome/version.gni")
11 import("//third_party/icu/config.gni") 11 import("//third_party/icu/config.gni")
12 import("//ui/base/ui_features.gni") 12 import("//ui/base/ui_features.gni")
13 import("//v8/gni/v8.gni") 13 import("//v8/gni/v8.gni")
14 14
15 config("mini_installer_compiler_flags") { 15 config("mini_installer_compiler_flags") {
16 # Disable buffer security checking. 16 # Disable buffer security checking.
17 cflags = [ "/GS-" ] 17 cflags = [ "/GS-" ]
18 } 18 }
19 19
20 source_set("lib") { 20 source_set("lib") {
(...skipping 23 matching lines...) Expand all
44 # This input dependency on the mini installer test Python files will force a 44 # This input dependency on the mini installer test Python files will force a
45 # recompilation when any of the Python files have changed. This will then 45 # recompilation when any of the Python files have changed. This will then
46 # invalidate the build and trigger running the test on the bots even when 46 # invalidate the build and trigger running the test on the bots even when
47 # no other Chrome files have changed. These have to be inputs rather than a 47 # no other Chrome files have changed. These have to be inputs rather than a
48 # dependency because a dependency won't actually trigger recompiles in 48 # dependency because a dependency won't actually trigger recompiles in
49 # incremental build cases unless a source file actually references one of the 49 # incremental build cases unless a source file actually references one of the
50 # dependency outputs. 50 # dependency outputs.
51 inputs = mini_installer_test_files 51 inputs = mini_installer_test_files
52 } 52 }
53 53
54 process_version("version") { 54 process_version_rc_template("version") {
55 template_file = "mini_installer_exe_version.rc.version" 55 template_file = "mini_installer_exe_version.rc.version"
56 output = "$root_out_dir/mini_installer_exe_version.rc" 56 output = "$root_out_dir/mini_installer_exe_version.rc"
57 } 57 }
58 58
59 source_set("unit_tests") { 59 source_set("unit_tests") {
60 testonly = true 60 testonly = true
61 61
62 sources = [ 62 sources = [
63 "configuration_test.cc", 63 "configuration_test.cc",
64 "decompress_test.cc", 64 "decompress_test.cc",
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 args = [ 287 args = [
288 "--out", 288 "--out",
289 "$target_name.exe", 289 "$target_name.exe",
290 ] 290 ]
291 deps = [ 291 deps = [
292 ":mini_installer", 292 ":mini_installer",
293 "//chrome/installer/test:alternate_version_generator", 293 "//chrome/installer/test:alternate_version_generator",
294 ] 294 ]
295 } 295 }
296 } 296 }
OLDNEW
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698