Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: chrome/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
11 import("//build/config/ui.gni") 11 import("//build/config/ui.gni")
12 import("//build/config/win/console_app.gni") 12 import("//build/config/win/console_app.gni")
13 import("//build/config/win/manifest.gni") 13 import("//build/config/win/manifest.gni")
14 import("//chrome/chrome_repack_locales.gni") 14 import("//chrome/chrome_repack_locales.gni")
15 import("//chrome/common/features.gni") 15 import("//chrome/common/features.gni")
16 import("//chrome/version.gni") 16 import("//chrome/process_version_rc_template.gni")
17 import("//third_party/widevine/cdm/widevine.gni") 17 import("//third_party/widevine/cdm/widevine.gni")
18 import("//ui/base/ui_features.gni") 18 import("//ui/base/ui_features.gni")
19 import("//v8/gni/v8.gni") 19 import("//v8/gni/v8.gni")
20 20
21 if (enable_resource_whitelist_generation) { 21 if (enable_resource_whitelist_generation) {
22 android_resource_whitelist = "$root_gen_dir/chrome/resource_whitelist.txt" 22 android_resource_whitelist = "$root_gen_dir/chrome/resource_whitelist.txt"
23 } 23 }
24 24
25 if (is_android) { 25 if (is_android) {
26 import("//build/config/android/rules.gni") 26 import("//build/config/android/rules.gni")
(...skipping 1178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 "//content/public/child", 1205 "//content/public/child",
1206 "//third_party/WebKit/public:blink_devtools_frontend_resources", 1206 "//third_party/WebKit/public:blink_devtools_frontend_resources",
1207 ] 1207 ]
1208 1208
1209 if (enable_nacl) { 1209 if (enable_nacl) {
1210 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ] 1210 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
1211 } 1211 }
1212 } 1212 }
1213 1213
1214 if (is_win) { 1214 if (is_win) {
1215 process_version("chrome_exe_version") { 1215 process_version_rc_template("chrome_exe_version") {
1216 template_file = chrome_version_rc_template
1217 sources = [ 1216 sources = [
1218 "app/chrome_exe.ver", 1217 "app/chrome_exe.ver",
1219 ] 1218 ]
1220 output = "$target_gen_dir/chrome_exe_version.rc" 1219 output = "$target_gen_dir/chrome_exe_version.rc"
1221 } 1220 }
1222 1221
1223 process_version("chrome_dll_version") { 1222 process_version_rc_template("chrome_dll_version") {
1224 template_file = chrome_version_rc_template
1225 sources = [ 1223 sources = [
1226 "app/chrome_dll.ver", 1224 "app/chrome_dll.ver",
1227 ] 1225 ]
1228 output = "$target_gen_dir/chrome_dll_version.rc" 1226 output = "$target_gen_dir/chrome_dll_version.rc"
1229 } 1227 }
1230 1228
1231 # This manifest matches what GYP produces. It may not even be necessary. 1229 # This manifest matches what GYP produces. It may not even be necessary.
1232 windows_manifest("chrome_dll_manifest") { 1230 windows_manifest("chrome_dll_manifest") {
1233 sources = [ 1231 sources = [
1234 as_invoker_manifest, 1232 as_invoker_manifest,
1235 common_controls_manifest, 1233 common_controls_manifest,
1236 ] 1234 ]
1237 type = "dll" 1235 type = "dll"
1238 } 1236 }
1239 1237
1240 process_version("nacl64_exe_version") { 1238 process_version_rc_template("nacl64_exe_version") {
1241 template_file = chrome_version_rc_template
1242 sources = [ 1239 sources = [
1243 "app/nacl64_exe.ver", 1240 "app/nacl64_exe.ver",
1244 ] 1241 ]
1245 output = "$target_gen_dir/nacl64_exe_version.rc" 1242 output = "$target_gen_dir/nacl64_exe_version.rc"
1246 } 1243 }
1247 1244
1248 process_version("other_version") { 1245 process_version_rc_template("other_version") {
1249 template_file = chrome_version_rc_template
1250 sources = [ 1246 sources = [
1251 "app/other.ver", 1247 "app/other.ver",
1252 ] 1248 ]
1253 output = "$target_gen_dir/other_version.rc" 1249 output = "$target_gen_dir/other_version.rc"
1254 } 1250 }
1255 1251
1256 source_set("file_pre_reader") { 1252 source_set("file_pre_reader") {
1257 sources = [ 1253 sources = [
1258 "app/file_pre_reader_win.cc", 1254 "app/file_pre_reader_win.cc",
1259 "app/file_pre_reader_win.h", 1255 "app/file_pre_reader_win.h",
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1785 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1781 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1786 "//chrome/tools/build/linux/chrome-wrapper", 1782 "//chrome/tools/build/linux/chrome-wrapper",
1787 "//third_party/xdg-utils/scripts/xdg-mime", 1783 "//third_party/xdg-utils/scripts/xdg-mime",
1788 "//third_party/xdg-utils/scripts/xdg-settings", 1784 "//third_party/xdg-utils/scripts/xdg-settings",
1789 ] 1785 ]
1790 outputs = [ 1786 outputs = [
1791 "$root_out_dir/{{source_file_part}}", 1787 "$root_out_dir/{{source_file_part}}",
1792 ] 1788 ]
1793 } 1789 }
1794 } 1790 }
OLDNEW
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698