Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Fix chromecast Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 import("//build/config/chrome_build.gni")
8 import("//build/util/process_version.gni")
7 import("//build_overrides/v8.gni") 9 import("//build_overrides/v8.gni")
8 import("//chrome/android/chrome_public_apk_tmpl.gni") 10 import("//chrome/android/chrome_public_apk_tmpl.gni")
9 import("//chrome/common/features.gni") 11 import("//chrome/common/features.gni")
10 import("//chrome/version.gni")
11 import("//testing/test.gni") 12 import("//testing/test.gni")
12 import("//third_party/icu/config.gni") 13 import("//third_party/icu/config.gni")
13 import("//third_party/protobuf/proto_library.gni") 14 import("//third_party/protobuf/proto_library.gni")
14 import("channel.gni") 15 import("channel.gni")
15 import("java_sources.gni") 16 import("java_sources.gni")
16 17
17 manifest_package = "org.chromium.chrome" 18 manifest_package = "org.chromium.chrome"
18 19
19 chrome_public_jinja_variables = default_chrome_public_jinja_variables + 20 chrome_public_jinja_variables = default_chrome_public_jinja_variables +
20 [ "manifest_package=$manifest_package" ] 21 [ "manifest_package=$manifest_package" ]
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 "//ui/android:ui_java", 355 "//ui/android:ui_java",
355 google_play_services_library, 356 google_play_services_library,
356 ] 357 ]
357 srcjar_deps = [ "//base:base_build_config_gen" ] 358 srcjar_deps = [ "//base:base_build_config_gen" ]
358 } 359 }
359 360
360 chrome_version_java_dir = "$root_gen_dir/templates/chrome_version_java" 361 chrome_version_java_dir = "$root_gen_dir/templates/chrome_version_java"
361 chrome_version_java_file = "$chrome_version_java_dir/org/chromium/chrome/browser /ChromeVersionConstants.java" 362 chrome_version_java_file = "$chrome_version_java_dir/org/chromium/chrome/browser /ChromeVersionConstants.java"
362 process_version("chrome_version_java") { 363 process_version("chrome_version_java") {
363 template_file = "java/ChromeVersionConstants.java.version" 364 template_file = "java/ChromeVersionConstants.java.version"
365 sources = [
366 "//chrome/VERSION",
367 branding_file_path,
368 ]
364 output = chrome_version_java_file 369 output = chrome_version_java_file
365 extra_args = [ 370 extra_args = [
366 "-e", 371 "-e",
367 "CHANNEL=str.upper('$android_channel')", 372 "CHANNEL=str.upper('$android_channel')",
368 ] 373 ]
369 } 374 }
370 375
371 zip("chrome_version_srcjar") { 376 zip("chrome_version_srcjar") {
372 inputs = [ 377 inputs = [
373 chrome_version_java_file, 378 chrome_version_java_file,
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 instrumentation_test_apk("chrome_sync_shell_test_apk") { 677 instrumentation_test_apk("chrome_sync_shell_test_apk") {
673 apk_name = "ChromeSyncShellTest" 678 apk_name = "ChromeSyncShellTest"
674 apk_under_test = ":chrome_sync_shell_apk" 679 apk_under_test = ":chrome_sync_shell_apk"
675 android_manifest = chrome_sync_shell_test_apk_manifest 680 android_manifest = chrome_sync_shell_test_apk_manifest
676 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest" 681 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
677 deps = [ 682 deps = [
678 ":chrome_sync_shell_test_apk_java", 683 ":chrome_sync_shell_test_apk_java",
679 ] 684 ]
680 proguard_enabled = !is_java_debug 685 proguard_enabled = !is_java_debug
681 } 686 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698