Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2308313002: Clean up RuleSet::addChildRules() (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up RuleSet::addChildRules() This is a follow-up CL for https://codereview.chromium.org/2306903002. This CL also renames forEachTagSelector to forEachTagHistory in CSSSelector.cpp, addressing the comment of https://codereview.chromium.org/2306903002#msg33. BUG=643316 Committed: https://crrev.com/e8e5d4fd9c55fae3b6f6e06ba3ae0909e05992bf Cr-Commit-Position: refs/heads/master@{#416571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hayato
PTAL
4 years, 3 months ago (2016-09-05 03:24:48 UTC) #5
rune
lgtm
4 years, 3 months ago (2016-09-05 07:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308313002/1
4 years, 3 months ago (2016-09-06 01:40:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 01:44:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 01:46:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8e5d4fd9c55fae3b6f6e06ba3ae0909e05992bf
Cr-Commit-Position: refs/heads/master@{#416571}

Powered by Google App Engine
This is Rietveld 408576698