Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2308303003: [turbofan] Fold "boolean not"-like Selects into branches. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fold "boolean not"-like Selects into branches. Fold a Select that negates a boolean value, i.e. returning true in the false case and vice versa, into Branch users, similar to what we already do for Branch nodes with BooleanNot inputs. BUG=v8:5267 Committed: https://crrev.com/99e91aaeacf7ed12570530b4f48b8f93b023f876 Cr-Commit-Position: refs/heads/master@{#39149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/compiler/common-operator-reducer.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Benedikt Meurer
PTAL
4 years, 3 months ago (2016-09-05 05:45:32 UTC) #6
Franzi
LGTM but can we change the commit message to [turbofan] Fold "boolean not"-like Selects into ...
4 years, 3 months ago (2016-09-05 06:58:34 UTC) #7
Benedikt Meurer
On 2016/09/05 06:58:34, Franzi wrote: > LGTM but can we change the commit message to ...
4 years, 3 months ago (2016-09-05 06:59:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308303003/1
4 years, 3 months ago (2016-09-05 06:59:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 07:02:28 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 07:02:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99e91aaeacf7ed12570530b4f48b8f93b023f876
Cr-Commit-Position: refs/heads/master@{#39149}

Powered by Google App Engine
This is Rietveld 408576698