Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 23083003: Make brokenImage() a static member of ImageResource class (Closed)

Created:
7 years, 4 months ago by spartha
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

brokenImage() is now a static member of ImageResource class Changed the method signature and the function calls. No new testcases needed. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156407

Patch Set 1 #

Patch Set 2 : Rebaselined patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/fetch/ImageResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
spartha
I am working on a different patch where I needed access to the "brokenimage" object. ...
7 years, 4 months ago (2013-08-14 11:10:32 UTC) #1
Hajime Morrita
lgtm.
7 years, 4 months ago (2013-08-15 00:06:45 UTC) #2
Hajime Morrita
Ouch. Did I close this accidentally or did you? Feel free to open.
7 years, 4 months ago (2013-08-15 00:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/23083003/1
7 years, 4 months ago (2013-08-20 05:18:28 UTC) #4
spartha
On 2013/08/15 00:07:47, morrita1 wrote: > Ouch. Did I close this accidentally or did you? ...
7 years, 4 months ago (2013-08-20 05:20:14 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-20 05:32:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/23083003/10002
7 years, 4 months ago (2013-08-20 07:30:56 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-20 07:40:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/23083003/10002
7 years, 4 months ago (2013-08-20 18:59:53 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 19:44:47 UTC) #10
Message was sent while issue was closed.
Change committed as 156407

Powered by Google App Engine
This is Rietveld 408576698