third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2308283002: Allow seeding the random layout test order and write out seed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2308283002: Allow seeding the random layout test order and write out seed. (Closed)

Patch Set: Add random order seed to results file. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 67ca8bce188b6127c091266b79da0dc5c264aa6c..ea118b9385c233e6a4ecad4cdf12aacba9441b27 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -253,11 +253,8 @@ class Manager(object):

if self._options.order == 'natural':

tests_to_run.sort(key=self._port.test_key)

elif self._options.order == 'random':

- random.shuffle(tests_to_run)

- elif self._options.order == 'random-seeded':

- rnd = random.Random()

- rnd.seed(4) # http://xkcd.com/221/

- rnd.shuffle(tests_to_run)

+ tests_to_run.sort()

+ random.Random(self._options.seed).shuffle(tests_to_run)

tests_to_run, tests_in_other_chunks = self._finder.split_into_chunks(tests_to_run)

self._expectations.add_extra_skipped_tests(tests_in_other_chunks)

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | no next file with comments »