third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py - Issue 2308283002: Allow seeding the random layout test order and write out seed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

Issue 2308283002: Allow seeding the random layout test order and write out seed. (Closed)

Patch Set: Remove incomplete docstring change Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

index 235ca1090cff425945d310e3be69487421179f9c..f6ba401f494bbffb72bc6dbcbab1cdbf4cf51e2a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

@@ -126,11 +126,14 @@ class Testprinter(unittest.TestCase):

def test_print_config(self):

printer, err = self.get_printer()

- # FIXME: it's lame that i have to set these options directly.

+ # FIXME: Make it so these options don't have to be set directly.

+ # pylint: disable=protected-access

printer._options.pixel_tests = True

printer._options.new_baseline = True

printer._options.time_out_ms = 6000

printer._options.slow_time_out_ms = 12000

+ printer._options.order = 'random'

+ printer._options.seed = 1234

printer.print_config('/tmp')

self.assertIn("Using port 'test-mac-mac10.10'", err.getvalue())

self.assertIn('Test configuration: <mac10.10, x86, release>', err.getvalue())

@@ -141,6 +144,7 @@ class Testprinter(unittest.TestCase):

self.assertIn('Pixel tests enabled', err.getvalue())

self.assertIn('Command line:', err.getvalue())

self.assertIn('Regular timeout: ', err.getvalue())

+ self.assertIn('Using random order with seed: 1234', err.getvalue())

self.reset(err)

printer._options.quiet = True