Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 230823003: Add --last_week/-W option to my_activity.py (Closed)

Created:
6 years, 8 months ago by jsbell
Modified:
6 years, 8 months ago
Reviewers:
deymo, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add --last_week/-W option to my_activity.py Some weeks, writing snippets on Monday just doesn't happen. And during those weeks, doing date arithmetic then correctly formatting a U.S. date is too hard. R=szager@chromium.org, deymo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262723

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M my_activity.py View 3 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
jsbell
deymo@, szager@ - please take a look?
6 years, 8 months ago (2014-04-09 16:33:00 UTC) #1
szager1
lgtm https://codereview.chromium.org/230823003/diff/1/my_activity.py File my_activity.py (right): https://codereview.chromium.org/230823003/diff/1/my_activity.py#newcode705 my_activity.py:705: help='Use last quarter\'s dates, i.e. %s to %s' ...
6 years, 8 months ago (2014-04-09 17:05:49 UTC) #2
jsbell
6 years, 8 months ago (2014-04-09 17:14:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r262723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698