recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json - Issue 2308193002: Remove bogus master/builder/slave/force parameters from bot_update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

Issue 2308193002: Remove bogus master/builder/slave/force parameters from bot_update. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« recipe_modules/bot_update/example.py ('K') | « recipe_modules/bot_update/example.expected/tryjob_v8.json ('k') | recipe_modules/bot_update/resources/bot_update.py » ('j') | recipe_modules/bot_update/resources/bot_update.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

diff --git a/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json b/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

index 3fbe3974a1b198fe9f219550dab16691f6a9a475..4cabfbf18f5c104dd54c33a8c0eda5431ccf81b9 100644

--- a/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

+++ b/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

@@ -4,12 +4,6 @@

"python",

"-u",

"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

- "--master",

- "chromium.testing.master",

- "--builder",

- "TestBuilder",

- "--slave",

- "TestSlavename",

"--spec",

"cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",

"--root",

@@ -36,11 +30,25 @@

"name": "bot_update",

"~followup_annotations": [

+ "@@@STEP_TEXT@Some step text@@@",

"@@@STEP_LOG_LINE@json.output@{@@@",

- "@@@STEP_LOG_LINE@json.output@ \"did_run\": false, @@@",

- "@@@STEP_LOG_LINE@json.output@ \"patch_failure\": false@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"fixed_revisions\": {@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"src\": \"HEAD\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"src/v8\": \"HEAD\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ }, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"patch_failure\": false, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"patch_root\": \"src/v8\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"properties\": {@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"got_cr_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"got_cr_revision_cp\": \"refs/heads/master@{#170242}\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ }, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"root\": \"src\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"step_text\": \"Some step text\"@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

- "@@@STEP_LOG_END@json.output@@@"

+ "@@@STEP_LOG_END@json.output@@@",

+ "@@@SET_BUILD_PROPERTY@got_cr_revision@\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",

+ "@@@SET_BUILD_PROPERTY@got_cr_revision_cp@\"refs/heads/master@{#170242}\"@@@"

]

{