Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2308173002: Remove gypi integration from libaddressinput and openh264 (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gypi integration from libaddressinput and openh264 This inlines the .gypi variables and deletes the obsolete files. TBR=dpranke Committed: https://crrev.com/7c6995574745e19de53f2bb10ce3083c2a166a65 Cr-Commit-Position: refs/heads/master@{#416418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -574 lines) Patch
M third_party/libaddressinput/BUILD.gn View 6 chunks +74 lines, -38 lines 0 comments Download
D third_party/libaddressinput/libaddressinput.gyp View 1 chunk +0 lines, -155 lines 0 comments Download
M third_party/openh264/BUILD.gn View 4 chunks +190 lines, -11 lines 0 comments Download
D third_party/openh264/openh264.gyp View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/openh264/openh264.gypi View 1 chunk +0 lines, -264 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308173002/1
4 years, 3 months ago (2016-09-02 23:36:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 00:46:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c6995574745e19de53f2bb10ce3083c2a166a65 Cr-Commit-Position: refs/heads/master@{#416418}
4 years, 3 months ago (2016-09-03 00:49:13 UTC) #8
Dirk Pranke
4 years, 3 months ago (2016-09-06 01:05:18 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698