Addressing feedback from ValidatingAuthenticator CL

Addressing feedback from ValidatingAuthenticator CL

This change addresses comments left on
https://codereview.chromium.org/2277553002/ after it was checked in.

The comments were around improvements to the switch used to set the
current authenticator state.  I addressed them by removing the default
case (and leaving a comment on why) and moving the success case into the
switch.

BUG=617185
Committed: https://crrev.com/5e3932143c85ccc346653588c4e30441e506a59c
Cr-Commit-Position: refs/heads/master@{#416410}

[joedow, 2016-09-02 22:44:20]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-09-02 22:45:23]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-09-02 22:45:24]

PTAL!

[Sergey Ulanov, 2016-09-02 23:13:39]

lgtm

https://codereview.chromium.org/2308133002/diff/20001/remoting/protocol/valid...
File remoting/protocol/validating_authenticator.cc (right):

https://codereview.chromium.org/2308133002/diff/20001/remoting/protocol/valid...
remoting/protocol/validating_authenticator.cc:116: // No default statement
exists as we want the compiler to error out if a
Don't really need this comment - we don't have similar comments in other switch
statements.

[joedow, 2016-09-02 23:35:22]

Thanks!

[joedow, 2016-09-02 23:35:44]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-09-02 23:35:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2308133002/#ps40001
(title: "Addressing CR Feedback")

[commit-bot: I haz the power, 2016-09-02 23:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:30:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-03 00:34:05]

Description was changed from

==========
Addressing feedback from ValidatingAuthenticator CL

This change addresses comments left on
https://codereview.chromium.org/2277553002/ after it was checked in.

The comments were around improvements to the switch used to set the
current authenticator state.  I addressed them by removing the default
case (and leaving a comment on why) and moving the success case into the
switch.

BUG=617185
==========

to

==========
Addressing feedback from ValidatingAuthenticator CL

This change addresses comments left on
https://codereview.chromium.org/2277553002/ after it was checked in.

The comments were around improvements to the switch used to set the
current authenticator state.  I addressed them by removing the default
case (and leaving a comment on why) and moving the success case into the
switch.

BUG=617185

Committed: https://crrev.com/5e3932143c85ccc346653588c4e30441e506a59c
Cr-Commit-Position: refs/heads/master@{#416410}
==========

[commit-bot: I haz the power, 2016-09-03 00:34:06]

Patchset 3 (id:??) landed as
https://crrev.com/5e3932143c85ccc346653588c4e30441e506a59c
Cr-Commit-Position: refs/heads/master@{#416410}