Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: Source/core/plugins/PluginView.h

Issue 230813002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed broken layout tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | Source/web/WebPluginContainerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/plugins/PluginView.h
diff --git a/Source/core/plugins/PluginView.h b/Source/core/plugins/PluginView.h
index c1cdc2f61f392b5e8d1f2b48c5997dac77e07ee0..b7af6c68a45b66ada177df45b1c06c343e204adc 100644
--- a/Source/core/plugins/PluginView.h
+++ b/Source/core/plugins/PluginView.h
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2010 Apple Inc. All rights reserved.
* Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Opera Software ASA. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -29,6 +30,7 @@
#include "platform/Widget.h"
#include "platform/scroll/ScrollTypes.h"
#include "wtf/text/WTFString.h"
+#include <v8.h>
struct NPObject;
@@ -45,7 +47,7 @@ public:
virtual bool isPluginView() const OVERRIDE FINAL { return true; }
virtual blink::WebLayer* platformLayer() const { return 0; }
- virtual NPObject* scriptableObject() { return 0; }
+ virtual v8::Local<v8::Object> scriptableObject(v8::Isolate*) { return v8::Local<v8::Object>(); }
virtual bool getFormValue(String&) { return false; }
virtual bool wantsWheelEvents() { return false; }
virtual bool supportsKeyboardFocus() const { return false; }
« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | Source/web/WebPluginContainerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698