Source/bindings/core/v8/V8DOMActivityLogger.cpp - Issue 230813002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8DOMActivityLogger.cpp

Issue 230813002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased to current ToT (by raymes - fetched from https://codereview.chromium.org/426853002/) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptController.cpp ('K') | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp » ('j') | Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/V8DOMActivityLogger.cpp

diff --git a/Source/bindings/core/v8/V8DOMActivityLogger.cpp b/Source/bindings/core/v8/V8DOMActivityLogger.cpp

index f7456c2fdc60488cd19dbc1651f92d619cffbae9..546dec71e901c91361765260de80d57e4778165d 100644

--- a/Source/bindings/core/v8/V8DOMActivityLogger.cpp

+++ b/Source/bindings/core/v8/V8DOMActivityLogger.cpp

@@ -92,6 +92,7 @@ V8DOMActivityLogger* V8DOMActivityLogger::currentActivityLoggerIfIsolatedWorld()

if (!isolate->InContext())

return 0;

+ v8::HandleScope handleScope(isolate);

abarth-chromium 2014/07/29 17:34:21 Why is this handle scope needed?

Krzysztof Olczyk 2014/07/30 08:40:30 Done.

v8::Handle<v8::Context> context = isolate->GetCurrentContext();

if (context.IsEmpty() || !toDOMWindow(context))

return 0;