Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2308083002: Added service protocol cross-origin access from localhost for http requests (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added missing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M runtime/bin/vmservice/server.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cbernaschina
4 years, 3 months ago (2016-09-02 20:56:39 UTC) #3
cbernaschina
4 years, 3 months ago (2016-09-02 20:58:58 UTC) #4
rmacnak
lgtm
4 years, 3 months ago (2016-09-02 20:59:24 UTC) #5
cbernaschina
4 years, 3 months ago (2016-09-02 21:00:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b328e442f08c08dcb7a7750f9d0b7f38d4bc3c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698