Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2308063002: Rename blink::Prerender::referrer() to getReferrer(). (Closed)

Created:
4 years, 3 months ago by Łukasz Anforowicz
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews, Yoav Weiss, gavinp+prerender_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 Committed: https://crrev.com/606a6866e02fce0f710d2107ce2a6d6b7713bb48 Cr-Commit-Position: refs/heads/master@{#417044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/Prerender.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebPrerender.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Łukasz Anforowicz
eae@, could you please take a look?
4 years, 3 months ago (2016-09-02 19:58:56 UTC) #3
eae
LGTM
4 years, 3 months ago (2016-09-05 20:55:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308063002/1
4 years, 3 months ago (2016-09-07 20:01:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:36:07 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:37:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/606a6866e02fce0f710d2107ce2a6d6b7713bb48
Cr-Commit-Position: refs/heads/master@{#417044}

Powered by Google App Engine
This is Rietveld 408576698