|
|
Created:
4 years, 3 months ago by Łukasz Anforowicz Modified:
4 years, 3 months ago Reviewers:
eae CC:
chromium-reviews, blink-reviews, Yoav Weiss, gavinp+prerender_chromium.org, dcheng Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRename blink::Prerender::referrer() to getReferrer().
The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style. Right now we have a |Referrer| type and
a |referrer| accessor method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Referrer| being the name of both the type and the accessor method
(with both living in the same namespace).
Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
the type if it's easy and makes sense, or add "Get", ex. GetContext().
BUG=582312
Committed: https://crrev.com/606a6866e02fce0f710d2107ce2a6d6b7713bb48
Cr-Commit-Position: refs/heads/master@{#417044}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
lukasza@chromium.org changed reviewers: + eae@chromium.org
eae@, could you please take a look?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Rename blink::Prerender::referrer() to ...Referrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ========== to ========== Rename blink::Prerender::referrer() to GetReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ==========
Description was changed from ========== Rename blink::Prerender::referrer() to GetReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ========== to ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ==========
Description was changed from ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ========== to ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ========== to ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 ========== to ========== Rename blink::Prerender::referrer() to getReferrer(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |Referrer| type and a |referrer| accessor method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |Referrer| being the name of both the type and the accessor method (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 Committed: https://crrev.com/606a6866e02fce0f710d2107ce2a6d6b7713bb48 Cr-Commit-Position: refs/heads/master@{#417044} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/606a6866e02fce0f710d2107ce2a6d6b7713bb48 Cr-Commit-Position: refs/heads/master@{#417044} |