Handle errors in v8::ValueDeserializer by throwing exceptions.

Handle errors in v8::ValueDeserializer by throwing exceptions.

This restores the contract that all API methods that return Maybe<T> or
MaybeLocal<T> always throw an exception when they return nothing.

Since v8::ValueDeserializer::ReadHeader can now throw exceptions, it
needs a Local<Context> parameter so that it can set up execution state
(entering the context, etc.). The old method has been marked for
deprecation, but since this API is experimental I intend to remove it
as soon as I've removed the use from Blink.

value-serializer-unittest has been updated to expect an exception in
all decode failure cases.

BUG=chromium:148757, chromium:641964
Committed: https://crrev.com/5a97e955204c4782d9727e8248b12739720232ba
Cr-Commit-Position: refs/heads/master@{#39188}

[jbroman, 2016-09-02 19:18:04]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 19:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-02 19:19:54]

Description was changed from

==========
Handle errors in v8::ValueDeserializer by throwing exceptions.

This restores the contract that all API methods that return Maybe<T> or
MaybeLocal<T> always throw an exception when they return nothing.

BUG=chromium:148757,chromium:641964
==========

to

==========
Handle errors in v8::ValueDeserializer by throwing exceptions.

This restores the contract that all API methods that return Maybe<T> or
MaybeLocal<T> always throw an exception when they return nothing.

Since v8::ValueDeserializer::ReadHeader can now throw exceptions, it
needs a Local<Context> parameter so that it can set up execution state
(entering the context, etc.). The old method has been marked for
deprecation, but since this API is experimental I intend to remove it
as soon as I've removed the use from Blink.

value-serializer-unittest has been updated to expect an exception in
all decode failure cases.

BUG=chromium:148757,chromium:641964
==========

[jbroman, 2016-09-02 19:27:07]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 19:27:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 19:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 19:51:39]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-09-02 19:53:20]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2016-09-02 19:53:21]

haraken@ pointed out that the V8 API is supposed to promise that Maybe<T> and
MaybeLocal<T> return nothing only when there's an exception. For consistency,
this moves into that state (and so that we have the isolate pointer around, it
indicates failure with a boolean in PrivateData rather than by deleting it).

[Jakob Kummerow, 2016-09-05 11:33:11]

lgtm

[jbroman, 2016-09-06 02:58:07]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-09-06 02:58:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 03:24:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 03:25:01]

Description was changed from

==========
Handle errors in v8::ValueDeserializer by throwing exceptions.

This restores the contract that all API methods that return Maybe<T> or
MaybeLocal<T> always throw an exception when they return nothing.

Since v8::ValueDeserializer::ReadHeader can now throw exceptions, it
needs a Local<Context> parameter so that it can set up execution state
(entering the context, etc.). The old method has been marked for
deprecation, but since this API is experimental I intend to remove it
as soon as I've removed the use from Blink.

value-serializer-unittest has been updated to expect an exception in
all decode failure cases.

BUG=chromium:148757,chromium:641964
==========

to

==========
Handle errors in v8::ValueDeserializer by throwing exceptions.

This restores the contract that all API methods that return Maybe<T> or
MaybeLocal<T> always throw an exception when they return nothing.

Since v8::ValueDeserializer::ReadHeader can now throw exceptions, it
needs a Local<Context> parameter so that it can set up execution state
(entering the context, etc.). The old method has been marked for
deprecation, but since this API is experimental I intend to remove it
as soon as I've removed the use from Blink.

value-serializer-unittest has been updated to expect an exception in
all decode failure cases.

BUG=chromium:148757,chromium:641964

Committed: https://crrev.com/5a97e955204c4782d9727e8248b12739720232ba
Cr-Commit-Position: refs/heads/master@{#39188}
==========

[commit-bot: I haz the power, 2016-09-06 03:25:02]

Patchset 2 (id:??) landed as
https://crrev.com/5a97e955204c4782d9727e8248b12739720232ba
Cr-Commit-Position: refs/heads/master@{#39188}