Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4028)

Unified Diff: chrome/browser/nacl_host/pnacl_host_unittest.cc

Issue 23080004: Disabled all PnaclHostTest.*OverlappedMiss* tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ooops Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/pnacl_host_unittest.cc
diff --git a/chrome/browser/nacl_host/pnacl_host_unittest.cc b/chrome/browser/nacl_host/pnacl_host_unittest.cc
index 057744188516e8941081fac950672abe1ed91a59..e2d529d36539396c0d3f37dde1a98fcb239a5247 100644
--- a/chrome/browser/nacl_host/pnacl_host_unittest.cc
+++ b/chrome/browser/nacl_host/pnacl_host_unittest.cc
@@ -195,7 +195,8 @@ TEST_F(PnaclHostTest, TranslationErrors) {
EXPECT_EQ(0U, host_->pending_translations());
}
-TEST_F(PnaclHostTest, OverlappedMissesAfterTempReturn) {
+// crbug.com/272492; flaky on all platforms.
+TEST_F(PnaclHostTest, DISABLED_OverlappedMissesAfterTempReturn) {
nacl::PnaclCacheInfo info = GetTestCacheInfo();
GET_NEXE_FD(0, 0, false, info, false);
FlushQueues();
@@ -267,7 +268,8 @@ TEST_F(PnaclHostTest, OverlappedHitsAfterTempReturn) {
EXPECT_EQ(0U, host_->pending_translations());
}
-TEST_F(PnaclHostTest, OverlappedMissesRendererClosing) {
+// crbug.com/272492; flaky on all platforms.
+TEST_F(PnaclHostTest, DISABLED_OverlappedMissesRendererClosing) {
nacl::PnaclCacheInfo info = GetTestCacheInfo();
GET_NEXE_FD(0, 0, false, info, false);
// Send the 2nd fd request from a different renderer.
@@ -305,7 +307,8 @@ TEST_F(PnaclHostTest, Incognito) {
EXPECT_EQ(3, temp_callback_count_);
}
-TEST_F(PnaclHostTest, IncognitoOverlappedMiss) {
+// crbug.com/272492; flaky on all platforms.
+TEST_F(PnaclHostTest, DISABLED_IncognitoOverlappedMiss) {
nacl::PnaclCacheInfo info = GetTestCacheInfo();
GET_NEXE_FD(0, 0, true, info, false);
GET_NEXE_FD(0, 1, false, info, false);
@@ -329,7 +332,8 @@ TEST_F(PnaclHostTest, IncognitoOverlappedMiss) {
host_->RendererClosing(0);
}
-TEST_F(PnaclHostTest, IncognitoSecondOverlappedMiss) {
+// crbug.com/272492; flaky on all platforms.
+TEST_F(PnaclHostTest, DISABLED_IncognitoSecondOverlappedMiss) {
// If the non-incognito request comes first, it should
// behave exactly like OverlappedMissBeforeTempReturn
nacl::PnaclCacheInfo info = GetTestCacheInfo();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698